Add exclude rule filter in scanner results admin #13811
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
willdurand requested review from a team, bobsilverberg and diox and removed request for a team 
Member Author
| Also requesting @diox's review because we discussed this issue during today's meeting. |
diox reviewed Mar 24, 2020
| ] | ||
| | ||
| | ||
| class ExcludeMatchedRuleFilter(SimpleListFilter): |
Member
There was a problem hiding this comment.
I would have expected you to inherit from ScannerRuleListFilter which takes care of the choices/lookups for you, you just have to customize the queryset. Did you look into that ? Does that not work ?
Member Author
There was a problem hiding this comment.
I wasn't able to customize the default entry. With this patch, it looks like this (and that will, hopefully, avoid confusions):
diox approved these changes Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes mozilla/addons#7281
We decided to fix the issue above by excluding a single rule at a time (for now).