Refactor #30235 ⁃ [TabScrollController refactor] Use transform instead of constraints to animate toolbars #30255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
🧹 Tidy commitJust 2 file(s) touched. Thanks for keeping it clean and review-friendly! 💬 Description craftsmanGreat PR description! Reviewers salute you 🫡 ❌ Per-file test coverage gateThe following changed file(s) are below 35.0% coverage:
Client.app: Coverage: 37.09
Generated by 🚫 Danger Swift against 116860b |
FilippoZazzeroni approved these changes Nov 4, 2025
Collaborator
FilippoZazzeroni left a comment
FilippoZazzeroni left a comment There was a problem hiding this comment.
Looks Great to me @yoanarios, just a super nit comment.
| let topOffset = clamp(offset: originTop - clampProgress, min: headerOffset, max: 0) | ||
| headerTopConstraint?.update(offset: topOffset) | ||
| header.superview?.layoutIfNeeded() | ||
| let isCollapsing = (state == .collapsed) |
Collaborator
There was a problem hiding this comment.
nit: i think we can remove the brackets
Contributor Author
There was a problem hiding this comment.
true, I will fix in my next PR
yoanarios deleted the yrd/FXIOS-13951-refactor-use-transform-to-animate-toolbars branch 
Contributor
| 🚀 PR merged to |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
📜 Tickets
Jira ticket
Github issue
💡 Description
Use transform in animation instead of changing view constraints. There is still tweaks needed I notice some jumps when the views shows but there is not enough translation so it's canceled but visually it was shown completely
Simulator.Screen.Recording.-.iPhone.17.-.2025-10-29.at.15.22.12.mov
📝 Checklist