build(cmake): Avoid overwriting include directories #221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
- Adds guard-checks against overwriting include directories passed as flags/inherited by cmake. - Also adds find_files hints for linuxbrex directories (homebrew for linux)
ditsuke force-pushed the build/avoid-overwriting-include-path branch from 2a25d50 to a0b5ec0 Compare 12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Context
While attempting to package this library for Nix, I discovered the Cmake configuration here is overwriting include directories passed as cmake flags.
Summary
I add guard checks to avoid overwriting include directories per expected behavior.