Skip to content

Correctly free resources in Uno Platform's SKXamlCanvas #3431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MartinZikmund wants to merge 2 commits into
base: main
Choose a base branch
from
+20 −14
Open

Correctly free resources in Uno Platform's SKXamlCanvas #3431

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
64fc95a
Correctly free resources in Uno Platform's `SKXamlCanvas`
MartinZikmund Dec 15, 2025
c05fa83
Adjust ordering for clarity
MartinZikmund Dec 15, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 20 additions & 14 deletions source/SkiaSharp.Views.Uno/SkiaSharp.Views.Uno.WinUI.Skia/SKXamlCanvas.Skia.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,11 @@ public SKXamlCanvas()
Initialize();
}

partial void DoUnloaded() =>
partial void DoUnloaded()
{
FreeBitmap();
FreePixels();
}

private void DoInvalidate()
{
Expand Down Expand Up @@ -83,8 +86,21 @@ private SKImageInfo CreateBitmap(out SKSizeI unscaledSize, out float dpi)
var size = CreateSize(out unscaledSize, out dpi);
var info = new SKImageInfo(size.Width, size.Height, SKColorType.Bgra8888, SKAlphaType.Premul);

if (pixels == null || pixelWidth != info.Width || pixelHeight != info.Height)
{
FreePixels();

pixels = new byte[info.BytesSize];
pixelsHandle = GCHandle.Alloc(pixels, GCHandleType.Pinned);

pixelWidth = info.Width;
pixelHeight = info.Height;
}

if (bitmap?.PixelWidth != info.Width || bitmap?.PixelHeight != info.Height)
{
FreeBitmap();
}

if (bitmap == null && info.Width > 0 && info.Height > 0)
{
Expand All @@ -101,28 +117,18 @@ private SKImageInfo CreateBitmap(out SKSizeI unscaledSize, out float dpi)
Background = brush;
}

if (pixels == null || pixelWidth != info.Width || pixelHeight != info.Height)
{
FreeBitmap();

pixels = new byte[info.BytesSize];
pixelsHandle = GCHandle.Alloc(pixels, GCHandleType.Pinned);

pixelWidth = info.Width;
pixelHeight = info.Height;
}

return info;
}

private void FreeBitmap()
private void FreePixels()
{
if (pixels != null)
{
pixelsHandle.Free();
pixels = null;
bitmap = null;
}
}

private void FreeBitmap() => _bitmap = null;
}
}
Loading