Use the original lib repo, not copied sources #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Use Mongoose OS module feature to separately source and build the original milesburton's DallasTemperature Arduino library instead of the outdated bundled fork.
| Question: is it beneficial to pin the module to a the current known-to-work version or commit? yeah, i think so. let's pin to current master. |
| OK, I've set |
| LG |
| thanks! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Use Mongoose OS module feature to separately source and build the original
milesburton's DallasTemperature Arduino library instead of the outdated bundled
fork.
(Probably also neatly keeps licencing separate: the original is LGPL 2, the wrapper is Apache 2.)
(NB! Won't build until mongoose-os-libs/arduino-compat#7 is merged!)
(Question: is it beneficial to pin the module to a the current known-to-work version or commit?)