- Notifications
You must be signed in to change notification settings - Fork 203
chore: Replace fwtypes.JSONStringType with jsontypes.NormalizedType #3452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
lantoli commented Jul 1, 2025
@@ -131,6 +131,7 @@ func (r *MockRoundTripper) nextDiffResponseIndex() { | |||
step := r.currentStep() | |||
if step == nil { | |||
r.t.Fatal("no more steps, in testCase") | |||
return |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix linter:
Error: internal/testutil/unit/http_mocker_round_tripper.go:132:5: SA5011(related information): this check suggests that the pointer can be nil (staticcheck) if step == nil { ^ Error: internal/testutil/unit/http_mocker_round_tripper.go:135:31: SA5011: possible nil pointer dereference (staticcheck)
EspenAlbert approved these changes Jul 1, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
lantoli added a commit that referenced this pull request Jul 4, 2025
* chore: Creates temporary workflow to create a test tag using Github actions (#3440) * chore: Use rebase instead of merge to update dev branches (#3442) * use rebase instead of merge to update dev branches * Update .github/workflows/update-dev-branches.yml Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * improve doc --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * chore: Updates repository to use supported Terraform versions (#3450) Co-authored-by: maastha <122359335+maastha@users.noreply.github.com> * chore: JSON attributes in auto-generated resources (#3445) * stream_processor_api config * marshal JSON custom type * generate JSON custom type * formatGoFile * generated code * acc test * fix resouce.tmpl imports * revert changes to template * add import for custom types * wait * marshal tests * autogen tests * acc test with update of equivalent pipeline JSON * unmarshal test for custom type list * marshal error test * join acc tests * update generated code * fix marshal tests * fix delete config * same config as curated resource * chore: Use SP10 instead of default SP30 for stream_instance acceptance tests (#3453) * use SP10 instead of default SP30 for stream_instance * fix linter * Revert "fix linter" This reverts commit 46270c0. * chore: Replace fwtypes.JSONStringType with jsontypes.NormalizedType (#3452) * use JSON custom type * fix linter * chore: Updates Atlas Go SDK (#3446) * build(deps): bump go.mongodb.org/atlas-sdk * sdk changes --------- Co-authored-by: oarbusi <55513886+oarbusi@users.noreply.github.com> Co-authored-by: Oriol Arbusi Abadal <oriol.abadal@mongodb.com> * doc: Updates Terraform Compatibility Matrix documentation (#3449) Co-authored-by: maastha <122359335+maastha@users.noreply.github.com> * chore: Remove `links` attributes in auto-generated resources (#3455) * remove links attributes * move comment * chore: Fixes broken link because of ending parenthesis. (#3448) * chore: Fixes broken link because of ending parenthesis. * using link markdown syntax to avoid broken link --------- Co-authored-by: Agustin Bettati <bettatiagustin@gmail.com> * feat: Adds `send_user_provided_resource_tags` attribute for `mongodbatlas_third_party_integration` (#3454) * add send_user_provided_resource_tags * changelog * fmt * docs and example * test * refactor * rename files * new line * chore: Updates CHANGELOG.md for #3454 * chore: Singletons in auto-generated resources (#3458) * initial auditing_api and maintenance_window_api generation * fix unmarshal for empty JSON * improve maintenance_window_api * checkDestroy in manual resource tests * explicit version header * check apiResp is not nil * support FixedRequestBody * auditing except delete * support FixedRequestBody * comment in MakeApiError * comment Unmarshal * use same flow as in SDK * rename FixedRequestBody to StaticRequestBody * codegen tests * revert unneeded test * lowering timeout value to ensure creation fails consistently (#3462) * doc: Fixing inconsistent docs in `federated_settings_org_role_mapping` associated to required attributes (#3460) * fixing inconsistent documentation * remove human-readable term in external_group_id attribute * fix: Avoids 0 itemsPerPage and pageNum when the args are missing in plural data sources (#3459) * chore: Add windsurf ignore * fix: Standardizes API params with WithParams pattern and IntPtr conversion * chore: Adds changelog file * refactor: use ListBackupExportJobsWithParams for export job listing * chore: Updates CHANGELOG.md for #3459 * feat: Adds `users` attribute to `mongodbatlas_project` singular data source (#3439) * WIP * Fixed acceptance test * Added a comment * Added changelog * Update docs/data-sources/project.md * Update .changelog/3439.txt Co-authored-by: Leo Antoli <430982+lantoli@users.noreply.github.com> * PR comments * Fix * Arguments fixed * Fix constant --------- Co-authored-by: Cristina Sánchez Sánchez <cristina.sanchez@mongodb.com> Co-authored-by: maastha <122359335+maastha@users.noreply.github.com> Co-authored-by: Leo Antoli <430982+lantoli@users.noreply.github.com> * feat: Adds users attribute to mongodbatlas_projects plural data source (#3451) * WIP * Fixed acceptance test * Added a comment * Added changelog * Added users attribute to projects data source * Added changelog and fixed docs * Factored out users schema * Refactored schemas and fixed test and doc * Minor code review suggestions and fixed doc --------- Co-authored-by: Cristina Sánchez Sánchez <cristina.sanchez@mongodb.com> --------- Co-authored-by: maastha <122359335+maastha@users.noreply.github.com> Co-authored-by: Leo Antoli <430982+lantoli@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: oarbusi <55513886+oarbusi@users.noreply.github.com> Co-authored-by: Oriol Arbusi Abadal <oriol.abadal@mongodb.com> Co-authored-by: Marco Suma <marco.suma@mongodb.com> Co-authored-by: Agustin Bettati <bettatiagustin@gmail.com> Co-authored-by: Espen Albert <EspenAlbert@users.noreply.github.com> Co-authored-by: Cristina Sánchez <c.sanchezprincipal@gmail.com> Co-authored-by: Cristina Sánchez Sánchez <cristina.sanchez@mongodb.com>
lantoli added a commit that referenced this pull request Jul 4, 2025
* feat: Adds `users` attribute to `mongodbatlas_project` singular data source (#3439) * WIP * Fixed acceptance test * Added a comment * Added changelog * Update docs/data-sources/project.md * Update .changelog/3439.txt Co-authored-by: Leo Antoli <430982+lantoli@users.noreply.github.com> * PR comments * Fix * Arguments fixed * Fix constant --------- Co-authored-by: Cristina Sánchez Sánchez <cristina.sanchez@mongodb.com> Co-authored-by: maastha <122359335+maastha@users.noreply.github.com> Co-authored-by: Leo Antoli <430982+lantoli@users.noreply.github.com> * feat: Adds users attribute to mongodbatlas_projects plural data source (#3451) * WIP * Fixed acceptance test * Added a comment * Added changelog * Added users attribute to projects data source * Added changelog and fixed docs * Factored out users schema * Refactored schemas and fixed test and doc * Minor code review suggestions and fixed doc --------- Co-authored-by: Cristina Sánchez Sánchez <cristina.sanchez@mongodb.com> * chore: Update CLOUDP-320243-dev-2.0.0 from master (#3457) * chore: Creates temporary workflow to create a test tag using Github actions (#3440) * chore: Use rebase instead of merge to update dev branches (#3442) * use rebase instead of merge to update dev branches * Update .github/workflows/update-dev-branches.yml Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * improve doc --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * chore: Updates repository to use supported Terraform versions (#3450) Co-authored-by: maastha <122359335+maastha@users.noreply.github.com> * chore: JSON attributes in auto-generated resources (#3445) * stream_processor_api config * marshal JSON custom type * generate JSON custom type * formatGoFile * generated code * acc test * fix resouce.tmpl imports * revert changes to template * add import for custom types * wait * marshal tests * autogen tests * acc test with update of equivalent pipeline JSON * unmarshal test for custom type list * marshal error test * join acc tests * update generated code * fix marshal tests * fix delete config * same config as curated resource * chore: Use SP10 instead of default SP30 for stream_instance acceptance tests (#3453) * use SP10 instead of default SP30 for stream_instance * fix linter * Revert "fix linter" This reverts commit 46270c0. * chore: Replace fwtypes.JSONStringType with jsontypes.NormalizedType (#3452) * use JSON custom type * fix linter * chore: Updates Atlas Go SDK (#3446) * build(deps): bump go.mongodb.org/atlas-sdk * sdk changes --------- Co-authored-by: oarbusi <55513886+oarbusi@users.noreply.github.com> Co-authored-by: Oriol Arbusi Abadal <oriol.abadal@mongodb.com> * doc: Updates Terraform Compatibility Matrix documentation (#3449) Co-authored-by: maastha <122359335+maastha@users.noreply.github.com> * chore: Remove `links` attributes in auto-generated resources (#3455) * remove links attributes * move comment * chore: Fixes broken link because of ending parenthesis. (#3448) * chore: Fixes broken link because of ending parenthesis. * using link markdown syntax to avoid broken link --------- Co-authored-by: Agustin Bettati <bettatiagustin@gmail.com> * feat: Adds `send_user_provided_resource_tags` attribute for `mongodbatlas_third_party_integration` (#3454) * add send_user_provided_resource_tags * changelog * fmt * docs and example * test * refactor * rename files * new line * chore: Updates CHANGELOG.md for #3454 * chore: Singletons in auto-generated resources (#3458) * initial auditing_api and maintenance_window_api generation * fix unmarshal for empty JSON * improve maintenance_window_api * checkDestroy in manual resource tests * explicit version header * check apiResp is not nil * support FixedRequestBody * auditing except delete * support FixedRequestBody * comment in MakeApiError * comment Unmarshal * use same flow as in SDK * rename FixedRequestBody to StaticRequestBody * codegen tests * revert unneeded test * lowering timeout value to ensure creation fails consistently (#3462) * doc: Fixing inconsistent docs in `federated_settings_org_role_mapping` associated to required attributes (#3460) * fixing inconsistent documentation * remove human-readable term in external_group_id attribute * fix: Avoids 0 itemsPerPage and pageNum when the args are missing in plural data sources (#3459) * chore: Add windsurf ignore * fix: Standardizes API params with WithParams pattern and IntPtr conversion * chore: Adds changelog file * refactor: use ListBackupExportJobsWithParams for export job listing * chore: Updates CHANGELOG.md for #3459 * feat: Adds `users` attribute to `mongodbatlas_project` singular data source (#3439) * WIP * Fixed acceptance test * Added a comment * Added changelog * Update docs/data-sources/project.md * Update .changelog/3439.txt Co-authored-by: Leo Antoli <430982+lantoli@users.noreply.github.com> * PR comments * Fix * Arguments fixed * Fix constant --------- Co-authored-by: Cristina Sánchez Sánchez <cristina.sanchez@mongodb.com> Co-authored-by: maastha <122359335+maastha@users.noreply.github.com> Co-authored-by: Leo Antoli <430982+lantoli@users.noreply.github.com> * feat: Adds users attribute to mongodbatlas_projects plural data source (#3451) * WIP * Fixed acceptance test * Added a comment * Added changelog * Added users attribute to projects data source * Added changelog and fixed docs * Factored out users schema * Refactored schemas and fixed test and doc * Minor code review suggestions and fixed doc --------- Co-authored-by: Cristina Sánchez Sánchez <cristina.sanchez@mongodb.com> --------- Co-authored-by: maastha <122359335+maastha@users.noreply.github.com> Co-authored-by: Leo Antoli <430982+lantoli@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: oarbusi <55513886+oarbusi@users.noreply.github.com> Co-authored-by: Oriol Arbusi Abadal <oriol.abadal@mongodb.com> Co-authored-by: Marco Suma <marco.suma@mongodb.com> Co-authored-by: Agustin Bettati <bettatiagustin@gmail.com> Co-authored-by: Espen Albert <EspenAlbert@users.noreply.github.com> Co-authored-by: Cristina Sánchez <c.sanchezprincipal@gmail.com> Co-authored-by: Cristina Sánchez Sánchez <cristina.sanchez@mongodb.com> --------- Co-authored-by: Cristina Sánchez <c.sanchezprincipal@gmail.com> Co-authored-by: Cristina Sánchez Sánchez <cristina.sanchez@mongodb.com> Co-authored-by: maastha <122359335+maastha@users.noreply.github.com> Co-authored-by: svc-apix-Bot <142542575+svc-apix-Bot@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: oarbusi <55513886+oarbusi@users.noreply.github.com> Co-authored-by: Oriol Arbusi Abadal <oriol.abadal@mongodb.com> Co-authored-by: Marco Suma <marco.suma@mongodb.com> Co-authored-by: Agustin Bettati <bettatiagustin@gmail.com> Co-authored-by: Espen Albert <EspenAlbert@users.noreply.github.com>
lantoli added a commit that referenced this pull request Jul 4, 2025
* feat: Adds `users` attribute to `mongodbatlas_project` singular data source (#3439) * WIP * Fixed acceptance test * Added a comment * Added changelog * Update docs/data-sources/project.md * Update .changelog/3439.txt Co-authored-by: Leo Antoli <430982+lantoli@users.noreply.github.com> * PR comments * Fix * Arguments fixed * Fix constant --------- Co-authored-by: Cristina Sánchez Sánchez <cristina.sanchez@mongodb.com> Co-authored-by: maastha <122359335+maastha@users.noreply.github.com> Co-authored-by: Leo Antoli <430982+lantoli@users.noreply.github.com> * feat: Adds users attribute to mongodbatlas_projects plural data source (#3451) * WIP * Fixed acceptance test * Added a comment * Added changelog * Added users attribute to projects data source * Added changelog and fixed docs * Factored out users schema * Refactored schemas and fixed test and doc * Minor code review suggestions and fixed doc --------- Co-authored-by: Cristina Sánchez Sánchez <cristina.sanchez@mongodb.com> * Added `users` attribute, modified test and docs. * Updated doc * chore: Update CLOUDP-320243-dev-2.0.0 from master (#3457) * chore: Creates temporary workflow to create a test tag using Github actions (#3440) * chore: Use rebase instead of merge to update dev branches (#3442) * use rebase instead of merge to update dev branches * Update .github/workflows/update-dev-branches.yml Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * improve doc --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * chore: Updates repository to use supported Terraform versions (#3450) Co-authored-by: maastha <122359335+maastha@users.noreply.github.com> * chore: JSON attributes in auto-generated resources (#3445) * stream_processor_api config * marshal JSON custom type * generate JSON custom type * formatGoFile * generated code * acc test * fix resouce.tmpl imports * revert changes to template * add import for custom types * wait * marshal tests * autogen tests * acc test with update of equivalent pipeline JSON * unmarshal test for custom type list * marshal error test * join acc tests * update generated code * fix marshal tests * fix delete config * same config as curated resource * chore: Use SP10 instead of default SP30 for stream_instance acceptance tests (#3453) * use SP10 instead of default SP30 for stream_instance * fix linter * Revert "fix linter" This reverts commit 46270c0. * chore: Replace fwtypes.JSONStringType with jsontypes.NormalizedType (#3452) * use JSON custom type * fix linter * chore: Updates Atlas Go SDK (#3446) * build(deps): bump go.mongodb.org/atlas-sdk * sdk changes --------- Co-authored-by: oarbusi <55513886+oarbusi@users.noreply.github.com> Co-authored-by: Oriol Arbusi Abadal <oriol.abadal@mongodb.com> * doc: Updates Terraform Compatibility Matrix documentation (#3449) Co-authored-by: maastha <122359335+maastha@users.noreply.github.com> * chore: Remove `links` attributes in auto-generated resources (#3455) * remove links attributes * move comment * chore: Fixes broken link because of ending parenthesis. (#3448) * chore: Fixes broken link because of ending parenthesis. * using link markdown syntax to avoid broken link --------- Co-authored-by: Agustin Bettati <bettatiagustin@gmail.com> * feat: Adds `send_user_provided_resource_tags` attribute for `mongodbatlas_third_party_integration` (#3454) * add send_user_provided_resource_tags * changelog * fmt * docs and example * test * refactor * rename files * new line * chore: Updates CHANGELOG.md for #3454 * chore: Singletons in auto-generated resources (#3458) * initial auditing_api and maintenance_window_api generation * fix unmarshal for empty JSON * improve maintenance_window_api * checkDestroy in manual resource tests * explicit version header * check apiResp is not nil * support FixedRequestBody * auditing except delete * support FixedRequestBody * comment in MakeApiError * comment Unmarshal * use same flow as in SDK * rename FixedRequestBody to StaticRequestBody * codegen tests * revert unneeded test * lowering timeout value to ensure creation fails consistently (#3462) * doc: Fixing inconsistent docs in `federated_settings_org_role_mapping` associated to required attributes (#3460) * fixing inconsistent documentation * remove human-readable term in external_group_id attribute * fix: Avoids 0 itemsPerPage and pageNum when the args are missing in plural data sources (#3459) * chore: Add windsurf ignore * fix: Standardizes API params with WithParams pattern and IntPtr conversion * chore: Adds changelog file * refactor: use ListBackupExportJobsWithParams for export job listing * chore: Updates CHANGELOG.md for #3459 * feat: Adds `users` attribute to `mongodbatlas_project` singular data source (#3439) * WIP * Fixed acceptance test * Added a comment * Added changelog * Update docs/data-sources/project.md * Update .changelog/3439.txt Co-authored-by: Leo Antoli <430982+lantoli@users.noreply.github.com> * PR comments * Fix * Arguments fixed * Fix constant --------- Co-authored-by: Cristina Sánchez Sánchez <cristina.sanchez@mongodb.com> Co-authored-by: maastha <122359335+maastha@users.noreply.github.com> Co-authored-by: Leo Antoli <430982+lantoli@users.noreply.github.com> * feat: Adds users attribute to mongodbatlas_projects plural data source (#3451) * WIP * Fixed acceptance test * Added a comment * Added changelog * Added users attribute to projects data source * Added changelog and fixed docs * Factored out users schema * Refactored schemas and fixed test and doc * Minor code review suggestions and fixed doc --------- Co-authored-by: Cristina Sánchez Sánchez <cristina.sanchez@mongodb.com> --------- Co-authored-by: maastha <122359335+maastha@users.noreply.github.com> Co-authored-by: Leo Antoli <430982+lantoli@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: oarbusi <55513886+oarbusi@users.noreply.github.com> Co-authored-by: Oriol Arbusi Abadal <oriol.abadal@mongodb.com> Co-authored-by: Marco Suma <marco.suma@mongodb.com> Co-authored-by: Agustin Bettati <bettatiagustin@gmail.com> Co-authored-by: Espen Albert <EspenAlbert@users.noreply.github.com> Co-authored-by: Cristina Sánchez <c.sanchezprincipal@gmail.com> Co-authored-by: Cristina Sánchez Sánchez <cristina.sanchez@mongodb.com> * Fixed test * Added changelog --------- Co-authored-by: Cristina Sánchez <c.sanchezprincipal@gmail.com> Co-authored-by: Cristina Sánchez Sánchez <cristina.sanchez@mongodb.com> Co-authored-by: maastha <122359335+maastha@users.noreply.github.com> Co-authored-by: svc-apix-Bot <142542575+svc-apix-Bot@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: oarbusi <55513886+oarbusi@users.noreply.github.com> Co-authored-by: Oriol Arbusi Abadal <oriol.abadal@mongodb.com> Co-authored-by: Marco Suma <marco.suma@mongodb.com> Co-authored-by: Agustin Bettati <bettatiagustin@gmail.com> Co-authored-by: Espen Albert <EspenAlbert@users.noreply.github.com>
svc-apix-Bot added a commit that referenced this pull request Jul 4, 2025
* chore: Creates temporary workflow to create a test tag using Github actions (#3440) * chore: Use rebase instead of merge to update dev branches (#3442) * use rebase instead of merge to update dev branches * Update .github/workflows/update-dev-branches.yml Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * improve doc --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * chore: Updates repository to use supported Terraform versions (#3450) Co-authored-by: maastha <122359335+maastha@users.noreply.github.com> * chore: JSON attributes in auto-generated resources (#3445) * stream_processor_api config * marshal JSON custom type * generate JSON custom type * formatGoFile * generated code * acc test * fix resouce.tmpl imports * revert changes to template * add import for custom types * wait * marshal tests * autogen tests * acc test with update of equivalent pipeline JSON * unmarshal test for custom type list * marshal error test * join acc tests * update generated code * fix marshal tests * fix delete config * same config as curated resource * chore: Use SP10 instead of default SP30 for stream_instance acceptance tests (#3453) * use SP10 instead of default SP30 for stream_instance * fix linter * Revert "fix linter" This reverts commit 46270c0. * chore: Replace fwtypes.JSONStringType with jsontypes.NormalizedType (#3452) * use JSON custom type * fix linter * chore: Updates Atlas Go SDK (#3446) * build(deps): bump go.mongodb.org/atlas-sdk * sdk changes --------- Co-authored-by: oarbusi <55513886+oarbusi@users.noreply.github.com> Co-authored-by: Oriol Arbusi Abadal <oriol.abadal@mongodb.com> * doc: Updates Terraform Compatibility Matrix documentation (#3449) Co-authored-by: maastha <122359335+maastha@users.noreply.github.com> * chore: Remove `links` attributes in auto-generated resources (#3455) * remove links attributes * move comment * chore: Fixes broken link because of ending parenthesis. (#3448) * chore: Fixes broken link because of ending parenthesis. * using link markdown syntax to avoid broken link --------- Co-authored-by: Agustin Bettati <bettatiagustin@gmail.com> * feat: Adds `send_user_provided_resource_tags` attribute for `mongodbatlas_third_party_integration` (#3454) * add send_user_provided_resource_tags * changelog * fmt * docs and example * test * refactor * rename files * new line * chore: Updates CHANGELOG.md for #3454 * chore: Singletons in auto-generated resources (#3458) * initial auditing_api and maintenance_window_api generation * fix unmarshal for empty JSON * improve maintenance_window_api * checkDestroy in manual resource tests * explicit version header * check apiResp is not nil * support FixedRequestBody * auditing except delete * support FixedRequestBody * comment in MakeApiError * comment Unmarshal * use same flow as in SDK * rename FixedRequestBody to StaticRequestBody * codegen tests * revert unneeded test * lowering timeout value to ensure creation fails consistently (#3462) * doc: Fixing inconsistent docs in `federated_settings_org_role_mapping` associated to required attributes (#3460) * fixing inconsistent documentation * remove human-readable term in external_group_id attribute * fix: Avoids 0 itemsPerPage and pageNum when the args are missing in plural data sources (#3459) * chore: Add windsurf ignore * fix: Standardizes API params with WithParams pattern and IntPtr conversion * chore: Adds changelog file * refactor: use ListBackupExportJobsWithParams for export job listing * chore: Updates CHANGELOG.md for #3459 * feat: Adds `users` attribute to `mongodbatlas_project` singular data source (#3439) * WIP * Fixed acceptance test * Added a comment * Added changelog * Update docs/data-sources/project.md * Update .changelog/3439.txt Co-authored-by: Leo Antoli <430982+lantoli@users.noreply.github.com> * PR comments * Fix * Arguments fixed * Fix constant --------- Co-authored-by: Cristina Sánchez Sánchez <cristina.sanchez@mongodb.com> Co-authored-by: maastha <122359335+maastha@users.noreply.github.com> Co-authored-by: Leo Antoli <430982+lantoli@users.noreply.github.com> * feat: Adds users attribute to mongodbatlas_projects plural data source (#3451) * WIP * Fixed acceptance test * Added a comment * Added changelog * Added users attribute to projects data source * Added changelog and fixed docs * Factored out users schema * Refactored schemas and fixed test and doc * Minor code review suggestions and fixed doc --------- Co-authored-by: Cristina Sánchez Sánchez <cristina.sanchez@mongodb.com> --------- Co-authored-by: maastha <122359335+maastha@users.noreply.github.com> Co-authored-by: Leo Antoli <430982+lantoli@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: oarbusi <55513886+oarbusi@users.noreply.github.com> Co-authored-by: Oriol Arbusi Abadal <oriol.abadal@mongodb.com> Co-authored-by: Marco Suma <marco.suma@mongodb.com> Co-authored-by: Agustin Bettati <bettatiagustin@gmail.com> Co-authored-by: Espen Albert <EspenAlbert@users.noreply.github.com> Co-authored-by: Cristina Sánchez <c.sanchezprincipal@gmail.com> Co-authored-by: Cristina Sánchez Sánchez <cristina.sanchez@mongodb.com>
lantoli added a commit that referenced this pull request Jul 4, 2025
* chore: Creates temporary workflow to create a test tag using Github actions (#3440) * chore: Use rebase instead of merge to update dev branches (#3442) * use rebase instead of merge to update dev branches * Update .github/workflows/update-dev-branches.yml Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * improve doc --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * chore: Updates repository to use supported Terraform versions (#3450) Co-authored-by: maastha <122359335+maastha@users.noreply.github.com> * chore: JSON attributes in auto-generated resources (#3445) * stream_processor_api config * marshal JSON custom type * generate JSON custom type * formatGoFile * generated code * acc test * fix resouce.tmpl imports * revert changes to template * add import for custom types * wait * marshal tests * autogen tests * acc test with update of equivalent pipeline JSON * unmarshal test for custom type list * marshal error test * join acc tests * update generated code * fix marshal tests * fix delete config * same config as curated resource * chore: Use SP10 instead of default SP30 for stream_instance acceptance tests (#3453) * use SP10 instead of default SP30 for stream_instance * fix linter * Revert "fix linter" This reverts commit 46270c0. * chore: Replace fwtypes.JSONStringType with jsontypes.NormalizedType (#3452) * use JSON custom type * fix linter * chore: Updates Atlas Go SDK (#3446) * build(deps): bump go.mongodb.org/atlas-sdk * sdk changes --------- Co-authored-by: oarbusi <55513886+oarbusi@users.noreply.github.com> Co-authored-by: Oriol Arbusi Abadal <oriol.abadal@mongodb.com> * doc: Updates Terraform Compatibility Matrix documentation (#3449) Co-authored-by: maastha <122359335+maastha@users.noreply.github.com> * chore: Remove `links` attributes in auto-generated resources (#3455) * remove links attributes * move comment * chore: Fixes broken link because of ending parenthesis. (#3448) * chore: Fixes broken link because of ending parenthesis. * using link markdown syntax to avoid broken link --------- Co-authored-by: Agustin Bettati <bettatiagustin@gmail.com> * feat: Adds `send_user_provided_resource_tags` attribute for `mongodbatlas_third_party_integration` (#3454) * add send_user_provided_resource_tags * changelog * fmt * docs and example * test * refactor * rename files * new line * chore: Updates CHANGELOG.md for #3454 * chore: Singletons in auto-generated resources (#3458) * initial auditing_api and maintenance_window_api generation * fix unmarshal for empty JSON * improve maintenance_window_api * checkDestroy in manual resource tests * explicit version header * check apiResp is not nil * support FixedRequestBody * auditing except delete * support FixedRequestBody * comment in MakeApiError * comment Unmarshal * use same flow as in SDK * rename FixedRequestBody to StaticRequestBody * codegen tests * revert unneeded test * lowering timeout value to ensure creation fails consistently (#3462) * doc: Fixing inconsistent docs in `federated_settings_org_role_mapping` associated to required attributes (#3460) * fixing inconsistent documentation * remove human-readable term in external_group_id attribute * fix: Avoids 0 itemsPerPage and pageNum when the args are missing in plural data sources (#3459) * chore: Add windsurf ignore * fix: Standardizes API params with WithParams pattern and IntPtr conversion * chore: Adds changelog file * refactor: use ListBackupExportJobsWithParams for export job listing * chore: Updates CHANGELOG.md for #3459 * chore: Docs team review improvements in dev branches (#3466) * TEMPORARY send to test channel * don't notify docs team if label skip-docs-notification * TEMPORARY doc change * add label skip label in update dev branches GHA * Revert "TEMPORARY doc change" This reverts commit de69883. * Revert "TEMPORARY send to test channel" This reverts commit c7e2746. * detect changes * don't create the PR is no new changes * fix linter * add step names * feat: Adds `users` attribute to `mongodbatlas_project` singular data source (#3439) * WIP * Fixed acceptance test * Added a comment * Added changelog * Update docs/data-sources/project.md * Update .changelog/3439.txt Co-authored-by: Leo Antoli <430982+lantoli@users.noreply.github.com> * PR comments * Fix * Arguments fixed * Fix constant --------- Co-authored-by: Cristina Sánchez Sánchez <cristina.sanchez@mongodb.com> Co-authored-by: maastha <122359335+maastha@users.noreply.github.com> Co-authored-by: Leo Antoli <430982+lantoli@users.noreply.github.com> * feat: Adds users attribute to mongodbatlas_projects plural data source (#3451) * WIP * Fixed acceptance test * Added a comment * Added changelog * Added users attribute to projects data source * Added changelog and fixed docs * Factored out users schema * Refactored schemas and fixed test and doc * Minor code review suggestions and fixed doc --------- Co-authored-by: Cristina Sánchez Sánchez <cristina.sanchez@mongodb.com> * chore: Update CLOUDP-320243-dev-2.0.0 from master (#3457) * chore: Creates temporary workflow to create a test tag using Github actions (#3440) * chore: Use rebase instead of merge to update dev branches (#3442) * use rebase instead of merge to update dev branches * Update .github/workflows/update-dev-branches.yml Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * improve doc --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * chore: Updates repository to use supported Terraform versions (#3450) Co-authored-by: maastha <122359335+maastha@users.noreply.github.com> * chore: JSON attributes in auto-generated resources (#3445) * stream_processor_api config * marshal JSON custom type * generate JSON custom type * formatGoFile * generated code * acc test * fix resouce.tmpl imports * revert changes to template * add import for custom types * wait * marshal tests * autogen tests * acc test with update of equivalent pipeline JSON * unmarshal test for custom type list * marshal error test * join acc tests * update generated code * fix marshal tests * fix delete config * same config as curated resource * chore: Use SP10 instead of default SP30 for stream_instance acceptance tests (#3453) * use SP10 instead of default SP30 for stream_instance * fix linter * Revert "fix linter" This reverts commit 46270c0. * chore: Replace fwtypes.JSONStringType with jsontypes.NormalizedType (#3452) * use JSON custom type * fix linter * chore: Updates Atlas Go SDK (#3446) * build(deps): bump go.mongodb.org/atlas-sdk * sdk changes --------- Co-authored-by: oarbusi <55513886+oarbusi@users.noreply.github.com> Co-authored-by: Oriol Arbusi Abadal <oriol.abadal@mongodb.com> * doc: Updates Terraform Compatibility Matrix documentation (#3449) Co-authored-by: maastha <122359335+maastha@users.noreply.github.com> * chore: Remove `links` attributes in auto-generated resources (#3455) * remove links attributes * move comment * chore: Fixes broken link because of ending parenthesis. (#3448) * chore: Fixes broken link because of ending parenthesis. * using link markdown syntax to avoid broken link --------- Co-authored-by: Agustin Bettati <bettatiagustin@gmail.com> * feat: Adds `send_user_provided_resource_tags` attribute for `mongodbatlas_third_party_integration` (#3454) * add send_user_provided_resource_tags * changelog * fmt * docs and example * test * refactor * rename files * new line * chore: Updates CHANGELOG.md for #3454 * chore: Singletons in auto-generated resources (#3458) * initial auditing_api and maintenance_window_api generation * fix unmarshal for empty JSON * improve maintenance_window_api * checkDestroy in manual resource tests * explicit version header * check apiResp is not nil * support FixedRequestBody * auditing except delete * support FixedRequestBody * comment in MakeApiError * comment Unmarshal * use same flow as in SDK * rename FixedRequestBody to StaticRequestBody * codegen tests * revert unneeded test * lowering timeout value to ensure creation fails consistently (#3462) * doc: Fixing inconsistent docs in `federated_settings_org_role_mapping` associated to required attributes (#3460) * fixing inconsistent documentation * remove human-readable term in external_group_id attribute * fix: Avoids 0 itemsPerPage and pageNum when the args are missing in plural data sources (#3459) * chore: Add windsurf ignore * fix: Standardizes API params with WithParams pattern and IntPtr conversion * chore: Adds changelog file * refactor: use ListBackupExportJobsWithParams for export job listing * chore: Updates CHANGELOG.md for #3459 * feat: Adds `users` attribute to `mongodbatlas_project` singular data source (#3439) * WIP * Fixed acceptance test * Added a comment * Added changelog * Update docs/data-sources/project.md * Update .changelog/3439.txt Co-authored-by: Leo Antoli <430982+lantoli@users.noreply.github.com> * PR comments * Fix * Arguments fixed * Fix constant --------- Co-authored-by: Cristina Sánchez Sánchez <cristina.sanchez@mongodb.com> Co-authored-by: maastha <122359335+maastha@users.noreply.github.com> Co-authored-by: Leo Antoli <430982+lantoli@users.noreply.github.com> * feat: Adds users attribute to mongodbatlas_projects plural data source (#3451) * WIP * Fixed acceptance test * Added a comment * Added changelog * Added users attribute to projects data source * Added changelog and fixed docs * Factored out users schema * Refactored schemas and fixed test and doc * Minor code review suggestions and fixed doc --------- Co-authored-by: Cristina Sánchez Sánchez <cristina.sanchez@mongodb.com> --------- Co-authored-by: maastha <122359335+maastha@users.noreply.github.com> Co-authored-by: Leo Antoli <430982+lantoli@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: oarbusi <55513886+oarbusi@users.noreply.github.com> Co-authored-by: Oriol Arbusi Abadal <oriol.abadal@mongodb.com> Co-authored-by: Marco Suma <marco.suma@mongodb.com> Co-authored-by: Agustin Bettati <bettatiagustin@gmail.com> Co-authored-by: Espen Albert <EspenAlbert@users.noreply.github.com> Co-authored-by: Cristina Sánchez <c.sanchezprincipal@gmail.com> Co-authored-by: Cristina Sánchez Sánchez <cristina.sanchez@mongodb.com> --------- Co-authored-by: maastha <122359335+maastha@users.noreply.github.com> Co-authored-by: Leo Antoli <430982+lantoli@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: oarbusi <55513886+oarbusi@users.noreply.github.com> Co-authored-by: Oriol Arbusi Abadal <oriol.abadal@mongodb.com> Co-authored-by: Marco Suma <marco.suma@mongodb.com> Co-authored-by: Agustin Bettati <bettatiagustin@gmail.com> Co-authored-by: Espen Albert <EspenAlbert@users.noreply.github.com> Co-authored-by: Cristina Sánchez <c.sanchezprincipal@gmail.com> Co-authored-by: Cristina Sánchez Sánchez <cristina.sanchez@mongodb.com>
lantoli added a commit that referenced this pull request Jul 4, 2025
* master: chore: Docs team review improvements in dev branches (#3466) chore: Updates CHANGELOG.md for #3459 fix: Avoids 0 itemsPerPage and pageNum when the args are missing in plural data sources (#3459) doc: Fixing inconsistent docs in `federated_settings_org_role_mapping` associated to required attributes (#3460) lowering timeout value to ensure creation fails consistently (#3462) chore: Singletons in auto-generated resources (#3458) chore: Updates CHANGELOG.md for #3454 feat: Adds `send_user_provided_resource_tags` attribute for `mongodbatlas_third_party_integration` (#3454) chore: Fixes broken link because of ending parenthesis. (#3448) chore: Remove `links` attributes in auto-generated resources (#3455) doc: Updates Terraform Compatibility Matrix documentation (#3449) chore: Updates Atlas Go SDK (#3446) chore: Replace fwtypes.JSONStringType with jsontypes.NormalizedType (#3452) chore: Use SP10 instead of default SP30 for stream_instance acceptance tests (#3453) chore: JSON attributes in auto-generated resources (#3445) chore: Updates repository to use supported Terraform versions (#3450) chore: Use rebase instead of merge to update dev branches (#3442) chore: Creates temporary workflow to create a test tag using Github actions (#3440) # Conflicts: # .github/workflows/update-dev-branches.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
Replace fwtypes.JSONStringType with jsontypes.NormalizedType.
In this way new JSON types will use the standard jsontypes.NormalizedType.
Link to any related issue(s): CLOUDP-307867
Type of change:
Required Checklist:
Further comments