- Notifications
You must be signed in to change notification settings - Fork 246
DRIVERS-2782: Expose snapshotTime #1843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
papafe wants to merge 18 commits into mongodb:master Choose a base branch from papafe:DRIVERS-2782
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
18 commits Select commit Hold shift + click to select a range
c9b29fe
[WIP] DRIVERS-2782 Expose snapshotTime
papafe 9765387
Fixed linting
papafe 364771e
Small fixes
papafe 1d581c6
Small fixes following review.
papafe 9d1da1b
Added prose test
papafe 610dc37
Added unified tests
papafe 63a6e0d
Added improvement to tests
papafe 4c4691c
Improved text.
papafe ff0582f
Corrected linting
papafe 4fdf701
Removed comments
papafe 48b70fc
Apply suggestion from @papafe
papafe de292a6
Added test
papafe df9d40d
Corrected test.
papafe d425f2b
Corrected test
papafe e640b2e
Added comment.
papafe 2f502f0
Moved comments
papafe 7151de1
Added comment for new operation
papafe c9171c0
Removed comment
papafe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for returning with this again, but I've just realized that we should mirror this changes into unified test format spec:
here: https://github.com/mongodb/specifications/blob/master/source/unified-test-format/unified-test-format.md#session-operations
and here: https://github.com/mongodb/specifications/blob/master/source/unified-test-format/unified-test-format.md#entity_session
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've mirrored this in the Session Operations section in unified test format spec. I did not modify the Entity Session section, as it already refers to the single spec documents, where I've already added the necessary info.