Skip to content

refactor(NODE-5170): update UnifiedMongoClient to make use of MongoDBLogWritable interface #3634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 19, 2023
Merged

refactor(NODE-5170): update UnifiedMongoClient to make use of MongoDBLogWritable interface #3634

merged 3 commits into from
Apr 19, 2023

Conversation

@W-A-James
Copy link
Contributor

@W-A-James W-A-James commented Apr 11, 2023 •
edited
Loading

Description

What is changing?

Updates UnifiedMongoClient to make use of the MongoDBLogWritable interface to collect and transform logs.

Is there new documentation needed for these changes?

No

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket
Base automatically changed from NODE-4813/Implement_severity_logging_methods to main April 14, 2023 19:58
@W-A-James W-A-James force-pushed the NODE-5170/update_unified_spec_test_runner branch from ddc1be8 to 39120a6 Compare April 14, 2023 20:51
@W-A-James W-A-James changed the title refactor(NODE-5170): change to use minimal interface refactor(NODE-5170): update UnifiedMongoClient to make use of MongoDBLogWritable interface Apr 14, 2023
@W-A-James W-A-James marked this pull request as ready for review April 14, 2023 20:54
@baileympearson baileympearson self-assigned this Apr 18, 2023
@baileympearson baileympearson added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Apr 18, 2023
baileympearson
baileympearson reviewed Apr 18, 2023
View reviewed changes
test/tools/unified-spec-runner/entities.ts Outdated
...getEnvironmentalOptions(),
...(description.serverApi ? { serverApi: description.serverApi } : {})
});
} as any);
Copy link
Contributor

@baileympearson baileympearson Apr 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of casting this as any, can we use a ts-expect-error and in the message, link to the jira ticket?

We expect this to have a TS error until add mongodbLogPath to the client options.
@baileympearson baileympearson merged commit b12922a into main Apr 19, 2023
@baileympearson baileympearson deleted the NODE-5170/update_unified_spec_test_runner branch April 19, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Primary Review In Review with primary reviewer, not yet ready for team's eyes

3 participants

@W-A-James @baileympearson