- Notifications
You must be signed in to change notification settings - Fork 23
CLOUDP-314903 [OIDC] CRD Config Propagation to Automation Config #60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cad403d to 0ce0874 Compare …-crd-propagation # Conflicts: # controllers/operator/authentication/authentication_mechanism.go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I think my comments just require clarification rather than changes.
docker/mongodb-kubernetes-tests/tests/webhooks/fixtures/invalid_oidc_mongodb_community.yaml Show resolved Hide resolved
docker/mongodb-kubernetes-tests/tests/webhooks/e2e_mongodb_validation_webhook.py Outdated Show resolved Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've left few comments: most are minor, but I've put a blocking one regarding MergoDelete.
I also miss a bit a proper e2e test verifying the automation config changes in a real world scenario.
| evergreen retry |
# Conflicts: # api/v1/mdb/mongodb_types.go
1f504cf to 633c456 Compare There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Great work 👏
Summary
Core Functionality Enhancements:
MongoDB-OIDC, to the list of supported mechanisms in theauthentication_mechanism.gofile.OIDCProviderConfigsfield in theAutomationConfigstruct and implemented logic to merge and apply OIDC configurations into the deployment in theautomation_config.gofile.groupClaimbecause the valuegroupscan result in hard to debug misconfiguration.API and Configuration Updates:
IsOIDCEnabled()method in theSecuritystruct andAuthResourceinterface to check if OIDC is enabled.Optionsstruct in theauthentication.gofile to includeOIDCProviderConfigs.Test Coverage:
automation_config_test.go, including scenarios for merging, clearing, and modifying configurations.TestAutomationConfigEqualitytest to include OIDC provider configurations.JSON Configuration Example:
automation_config.jsontest data file to include sample OIDC provider configurations for testing purposes.Proof of Work
Checklist
Reminder (Please remove this when merging)