- Notifications
You must be signed in to change notification settings - Fork 23
Renaming "MongoDB Enterprise" with "MongoDB Kubernetes" #52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
58fb4a2 to 162e4e9 Compare There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR replaces all references to "MongoDB Enterprise" with "MongoDB Kubernetes" to align the naming convention across the codebase.
- Updated Dockerfile.builder comments and license path in the operator directory
- Changed working directory reference in .evergreen-functions.yml to point to the new appdb directory
Reviewed Changes
Copilot reviewed 531 out of 537 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| docker/mongodb-kubernetes-operator/Dockerfile.builder | Updated build command comment and license path; however, the COPY command reference remains unchanged |
| .evergreen-functions.yml | Updated the working directory to the new kubernetes appdb directory |
Files not reviewed (6)
- .dockerignore: Language not supported
- Makefile: Language not supported
- docker/mongodb-kubernetes-database/Dockerfile.template: Language not supported
- docker/mongodb-kubernetes-init-database/Dockerfile.template: Language not supported
- docker/mongodb-kubernetes-init-ops-manager/Dockerfile.template: Language not supported
- docker/mongodb-kubernetes-operator/Dockerfile.template: Language not supported
Comments suppressed due to low confidence (1)
docker/mongodb-kubernetes-operator/Dockerfile.builder:48
- The COPY command still references 'mongodb-enterprise-operator'; it should be updated to 'mongodb-kubernetes-operator' for consistency with the new naming convention.
COPY --from=builder /build/mongodb-enterprise-operator /data/
lsierant left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
lucian-tosa left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this file be also updated?
mongodb-kubernetes/scripts/update_supported_dockerfiles.py
Lines 24 to 32 in 5a86b10
| SUPPORTED_IMAGES = ( | |
| "mongodb-agent", | |
| "mongodb-enterprise-database", | |
| "mongodb-enterprise-init-database", | |
| "mongodb-enterprise-init-appdb", | |
| "mongodb-enterprise-ops-manager", | |
| "mongodb-enterprise-init-ops-manager", | |
| "mongodb-enterprise-operator", | |
| ) |
| {%- if is_appdb %} | ||
| LABEL name="MongoDB Enterprise Init AppDB" \ | ||
| LABEL name="MongoDB Kubernetes Init AppDB" \ | ||
| version="mongodb-enterprise-init-appdb-${version}" \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we not changing the version label?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes - will do once some tests are green - will do the change and then merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for cathcing this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also check if update_supported_dockerfiles.py needs to be changed as well
Summary
This pull request introduces a comprehensive renaming effort to replace "MongoDB Enterprise" with "MongoDB Kubernetes" across various files and configurations. The changes primarily focus on updating paths, labels, and references to align with the new naming convention. Below is a summary of the most important changes, grouped by theme:
File and Path Updates:
.dockerignoreto replace thedocker/mongodb-enterprise-testsdirectory withdocker/mongodb-kubernetes-tests.docker/mongodb-enterprise-operatortodocker/mongodb-kubernetes-operatorand updated references inDockerfile.builderand related files. [1] [2]Makefile Adjustments:
Makefileto reflect the new directory structure and naming, including changes to paths for certificates, Python tests, and the operator binary. [1] [2] [3]Dockerfile Label Updates:
Dockerfile.templatefiles to reflect the new "MongoDB Kubernetes" naming for the database, init database, and Ops Manager init images. [1] [2] [3]docker/mongodb-enterprise-operator/Dockerfile.templatetodocker/mongodb-kubernetes-operator/Dockerfile.templateand updated its labels accordingly.Configuration Changes:
working_dirin.evergreen-functions.ymlto point to the newdocker/mongodb-kubernetes-appdb-databasedirectory.Proof of Work
Checklist
Reminder (Please remove this when merging)