Skip to content

Conversation

@nammn
Copy link
Collaborator

@nammn nammn commented Apr 28, 2025

Summary

This pull request introduces a comprehensive renaming effort to replace "MongoDB Enterprise" with "MongoDB Kubernetes" across various files and configurations. The changes primarily focus on updating paths, labels, and references to align with the new naming convention. Below is a summary of the most important changes, grouped by theme:

File and Path Updates:

  • Updated .dockerignore to replace the docker/mongodb-enterprise-tests directory with docker/mongodb-kubernetes-tests.
  • Renamed docker/mongodb-enterprise-operator to docker/mongodb-kubernetes-operator and updated references in Dockerfile.builder and related files. [1] [2]

Makefile Adjustments:

  • Updated the Makefile to reflect the new directory structure and naming, including changes to paths for certificates, Python tests, and the operator binary. [1] [2] [3]

Dockerfile Label Updates:

  • Updated labels in Dockerfile.template files to reflect the new "MongoDB Kubernetes" naming for the database, init database, and Ops Manager init images. [1] [2] [3]
  • Renamed docker/mongodb-enterprise-operator/Dockerfile.template to docker/mongodb-kubernetes-operator/Dockerfile.template and updated its labels accordingly.

Configuration Changes:

  • Adjusted the working_dir in .evergreen-functions.yml to point to the new docker/mongodb-kubernetes-appdb-database directory.

Proof of Work

  • green ci; like here: Patch

Checklist

  • Have you linked a jira ticket and/or is the ticket in the title?
  • Have you checked whether your jira ticket required DOCSP changes?
  • Have you checked for release_note changes?

Reminder (Please remove this when merging)

  • Please try to Approve or Reject Changes the PR, keep PRs in review as short as possible
  • Our Short Guide for PRs: Link
  • Remember the following Communication Standards - use comment prefixes for clarity:
    • blocking: Must be addressed before approval.
    • follow-up: Can be addressed in a later PR or ticket.
    • q: Clarifying question.
    • nit: Non-blocking suggestions.
    • note: Side-note, non-actionable. Example: Praise
    • --> no prefix is considered a question
@nammn nammn force-pushed the mck-convert-enterprise branch from 58fb4a2 to 162e4e9 Compare April 29, 2025 08:22
@nammn nammn requested a review from Copilot April 29, 2025 08:57
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR replaces all references to "MongoDB Enterprise" with "MongoDB Kubernetes" to align the naming convention across the codebase.

  • Updated Dockerfile.builder comments and license path in the operator directory
  • Changed working directory reference in .evergreen-functions.yml to point to the new appdb directory

Reviewed Changes

Copilot reviewed 531 out of 537 changed files in this pull request and generated no comments.

File Description
docker/mongodb-kubernetes-operator/Dockerfile.builder Updated build command comment and license path; however, the COPY command reference remains unchanged
.evergreen-functions.yml Updated the working directory to the new kubernetes appdb directory
Files not reviewed (6)
  • .dockerignore: Language not supported
  • Makefile: Language not supported
  • docker/mongodb-kubernetes-database/Dockerfile.template: Language not supported
  • docker/mongodb-kubernetes-init-database/Dockerfile.template: Language not supported
  • docker/mongodb-kubernetes-init-ops-manager/Dockerfile.template: Language not supported
  • docker/mongodb-kubernetes-operator/Dockerfile.template: Language not supported
Comments suppressed due to low confidence (1)

docker/mongodb-kubernetes-operator/Dockerfile.builder:48

  • The COPY command still references 'mongodb-enterprise-operator'; it should be updated to 'mongodb-kubernetes-operator' for consistency with the new naming convention.
COPY --from=builder /build/mongodb-enterprise-operator /data/ 
@nammn nammn changed the title rename all enterprise operator references to kubernetes operator Renaming "MongoDB Enterprise" with "MongoDB Kubernetes" Apr 29, 2025
@nammn nammn marked this pull request as ready for review April 29, 2025 09:52
@nammn nammn requested a review from a team as a code owner April 29, 2025 09:52
@nammn nammn requested review from anandsyncs and lucian-tosa April 29, 2025 09:52
Copy link
Contributor

@lsierant lsierant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nammn nammn changed the base branch from master to mck-merge-up-enterprise-rebased April 29, 2025 12:25
@nammn nammn changed the base branch from mck-merge-up-enterprise-rebased to master April 29, 2025 12:25
Copy link
Contributor

@lucian-tosa lucian-tosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this file be also updated?

SUPPORTED_IMAGES = (
"mongodb-agent",
"mongodb-enterprise-database",
"mongodb-enterprise-init-database",
"mongodb-enterprise-init-appdb",
"mongodb-enterprise-ops-manager",
"mongodb-enterprise-init-ops-manager",
"mongodb-enterprise-operator",
)

{%- if is_appdb %}
LABEL name="MongoDB Enterprise Init AppDB" \
LABEL name="MongoDB Kubernetes Init AppDB" \
version="mongodb-enterprise-init-appdb-${version}" \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we not changing the version label?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes - will do once some tests are green - will do the change and then merge

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for cathcing this!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also check if update_supported_dockerfiles.py needs to be changed as well

@nammn nammn merged commit 12d1b90 into master Apr 30, 2025
1 check was pending
@nammn nammn deleted the mck-convert-enterprise branch April 30, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

6 participants