Skip to content

Conversation

lucian-tosa
Copy link
Contributor

@lucian-tosa lucian-tosa commented Oct 10, 2025

Summary

This PR adds a new task running on arm64 to build the arm64 test image. Previously it was built using emulation on an amd64 resulting in a runtime of ~40 minutes.

Proof of Work

CI is green
Smoke test on ARM also green

Checklist

  • Have you linked a jira ticket and/or is the ticket in the title?
  • Have you checked whether your jira ticket required DOCSP changes?
  • Have you added changelog file?
@lucian-tosa lucian-tosa changed the title Improve e2e on arm CLOUDP-339241 - Improve e2e on arm Oct 13, 2025
# Conflicts: #	.evergreen-functions.yml #	.evergreen.yml #	scripts/dev/setup_evg_host.sh #	scripts/evergreen/e2e/single_e2e.sh #	scripts/release/build/build_info.py #	scripts/release/build/image_build_process.py #	scripts/release/pipeline.py
Copy link

github-actions bot commented Oct 13, 2025

⚠️ (this preview might not be accurate if the PR is not rebased on current master branch)

MCK 1.5.1 Release Notes

Bug Fixes

  • Fixed parsing of the customEnvVars Helm value when values contain = characters.
@lucian-tosa lucian-tosa added the skip-changelog Use this label in Pull Request to not require new changelog entry file label Oct 13, 2025

kubectl_version=$(curl --retry 5 -Ls https://dl.k8s.io/release/stable.txt)
echo "Downloading kubectl ${kubectl_version} for ${ARCH}"
kubectl_version=$(echo "${kubectl_version}" | tail -n1 | tr -d '\n')
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a quick fix for the intermittent failure of download_kube_tools function

@lucian-tosa lucian-tosa marked this pull request as ready for review October 14, 2025 14:10
@lucian-tosa lucian-tosa requested a review from a team as a code owner October 14, 2025 14:10
@filipcirtog filipcirtog removed their request for review October 15, 2025 08:44
@filipcirtog filipcirtog removed their request for review October 15, 2025 08:44
@Julien-Ben
Copy link
Collaborator

Awesome ! Thank you for the fix 🙏

platforms = get_platforms_from_arg(args.platform) or image_build_info.platforms
sign = args.sign if args.sign is not None else image_build_info.sign
skip_if_exists = args.skip_if_exists if args.skip_if_exists is not None else image_build_info.skip_if_exists
architecture_suffix = (
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: can you switch the condition to be exactly the same as the previous args? It helps with reading what will happen as you already understand the previous pattern

)
parser.add_argument(
"--architecture-suffix",
action=argparse.BooleanOptionalAction,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is great, I was not aware of this option! moving away from str2bool!

Copy link
Collaborator

@MaciejKaras MaciejKaras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit comment, but otherwise looks great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog Use this label in Pull Request to not require new changelog entry file

3 participants