- Notifications
You must be signed in to change notification settings - Fork 21
CLOUDP-339241 - Improve e2e on arm #515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
# Conflicts: # .evergreen-functions.yml # .evergreen.yml # scripts/dev/setup_evg_host.sh # scripts/evergreen/e2e/single_e2e.sh # scripts/release/build/build_info.py # scripts/release/build/image_build_process.py # scripts/release/pipeline.py
MCK 1.5.1 Release NotesBug Fixes
|
| ||
kubectl_version=$(curl --retry 5 -Ls https://dl.k8s.io/release/stable.txt) | ||
echo "Downloading kubectl ${kubectl_version} for ${ARCH}" | ||
kubectl_version=$(echo "${kubectl_version}" | tail -n1 | tr -d '\n') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a quick fix for the intermittent failure of download_kube_tools
function
# Conflicts: # scripts/release/pipeline.py
Awesome ! Thank you for the fix 🙏 |
platforms = get_platforms_from_arg(args.platform) or image_build_info.platforms | ||
sign = args.sign if args.sign is not None else image_build_info.sign | ||
skip_if_exists = args.skip_if_exists if args.skip_if_exists is not None else image_build_info.skip_if_exists | ||
architecture_suffix = ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: can you switch the condition to be exactly the same as the previous args? It helps with reading what will happen as you already understand the previous pattern
) | ||
parser.add_argument( | ||
"--architecture-suffix", | ||
action=argparse.BooleanOptionalAction, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is great, I was not aware of this option! moving away from str2bool
!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nit comment, but otherwise looks great!
Summary
This PR adds a new task running on arm64 to build the arm64 test image. Previously it was built using emulation on an amd64 resulting in a runtime of ~40 minutes.
Proof of Work
CI is green
Smoke test on ARM also green
Checklist
skip-changelog
label if not needed