Skip to content

Conversation

@lsierant
Copy link
Contributor

@lsierant lsierant commented Apr 25, 2025

Summary

It skips building arm64 docker images when building images in patches and in evergreen.
arm64 images takes long time to build probably due to emulation (>10min arm64 vs 10s amd64).

The change should not impact any daily build processes.

Proof of Work

Only manual run:
with skipped arm64, total time: 2min (link to relevant log message)
build from master: total time: 12min

Checklist

  • Have you linked a jira ticket and/or is the ticket in the title?
  • Have you checked whether your jira ticket required DOCSP changes?
  • Have you checked for release_note changes?

Reminder (Please remove this when merging)

  • Please try to Approve or Reject Changes the PR, keep PRs in review as short as possible
  • Our Short Guide for PRs: Link
  • Remember the following Communication Standards - use comment prefixes for clarity:
    • blocking: Must be addressed before approval.
    • follow-up: Can be addressed in a later PR or ticket.
    • q: Clarifying question.
    • nit: Non-blocking suggestions.
    • note: Side-note, non-actionable. Example: Praise
    • --> no prefix is considered a question
@lsierant lsierant force-pushed the lsierant/skip-arm64 branch 4 times, most recently from 2016cc0 to 8f425d8 Compare April 29, 2025 11:25
@lsierant lsierant force-pushed the lsierant/skip-arm64 branch from 8f425d8 to 6eb8fe0 Compare April 29, 2025 11:28
@lsierant lsierant marked this pull request as ready for review April 29, 2025 11:28
@lsierant lsierant requested a review from a team as a code owner April 29, 2025 11:28
Copy link
Collaborator

@MaciejKaras MaciejKaras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

"manifest",
"create",
final_manifest,
"--amend",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't think we even need the amend part anymore - since those images are always multiarch cc. @lucian-tosa

@lsierant lsierant merged commit 1c3b892 into master Apr 30, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants