Normalize GKE identifiers in snippets #458
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
MCK 1.4.1 Release Notes |
viveksinghggits approved these changes Sep 16, 2025
lsierant force-pushed the lsierant/normalize-gke-identifiers branch from ea13b04 to 4fa6b0e Compare 
lsierant commented Sep 16, 2025
| | ||
| curl -s --retry 3 -LO "https://dl.google.com/dl/cloudsdk/channels/rapid/downloads/google-cloud-cli-linux-x86_64.tar.gz" | ||
| tar xvf google-cloud-cli-linux-x86_64.tar.gz -C "${workdir}" | ||
| tar xf google-cloud-cli-linux-x86_64.tar.gz -C "${workdir}" |
There was a problem hiding this comment.
this saves >10k lines from persisting to the job log
fealebenpae approved these changes Sep 16, 2025
lsierant added the skip-changelog lsierant changed the base branch from master to fealebenpae/prerelease-code-snippets-om-version lsierant changed the base branch from fealebenpae/prerelease-code-snippets-om-version to master Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Summary
When executed from a tag build, the version_id is long and contains dots which are unacceptable by GKE.
Additionally it reduces verbose output when installing gcloud.
Proof of Work
EVG run with --param override_version_id=mongodb_kubernetes_1.4.0_68c913f767d52d00076a2698
Checklist
skip-changeloglabel if not needed