Skip to content

CLOUDP-315007 - update license #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 30, 2025
Merged

CLOUDP-315007 - update license #44

merged 4 commits into from
Apr 30, 2025

Conversation

@nammn
Copy link
Collaborator

@nammn nammn commented Apr 25, 2025 •
edited
Loading

Summary

Proof of Work

Checklist

  • Have you linked a jira ticket and/or is the ticket in the title?
  • Have you checked whether your jira ticket required DOCSP changes?
  • Have you checked for release_note changes?

Reminder (Please remove this when merging)

  • Please try to Approve or Reject Changes the PR, keep PRs in review as short as possible
  • Our Short Guide for PRs: Link
  • Remember the following Communication Standards - use comment prefixes for clarity:
    • blocking: Must be addressed before approval.
    • follow-up: Can be addressed in a later PR or ticket.
    • q: Clarifying question.
    • nit: Non-blocking suggestions.
    • note: Side-note, non-actionable. Example: Praise
    • --> no prefix is considered a question
@nammn nammn requested a review from a team as a code owner April 25, 2025 13:01
@nammn nammn requested review from MaciejKaras and anandsyncs April 25, 2025 13:01
@nammn nammn changed the title update license CLOUDP-315007 - update license Apr 25, 2025
@nammn nammn requested review from mircea-cosbuc and vinilage April 25, 2025 13:03
vinilage
vinilage reviewed Apr 25, 2025
View reviewed changes
LICENSE-SAMPLE-CODE Outdated
@@ -0,0 +1,178 @@
Copyright 2025 MongoDB, Inc.

Apache License
Copy link
Collaborator

@vinilage vinilage Apr 25, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[minor] Can you centralize this text, please? Checking other LICENSE files (example MongoDB Python driver) the "Apache License" is centralized (1).

(1) https://github.com/mongodb/mongo-python-driver/blob/master/LICENSE
Copy link
Collaborator Author

@nammn nammn Apr 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done; 0530c25
@nammn nammn requested a review from Copilot April 29, 2025 08:57
Copilot AI reviewed Apr 29, 2025
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 6 changed files in this pull request and generated no comments.

Files not reviewed (4)
  • .githooks/pre-commit: Language not supported
  • LICENSE-MCK: Language not supported
  • LICENSE-SAMPLE-CODE: Language not supported
  • scripts/evergreen/update_licenses.sh: Language not supported
@nammn nammn merged commit 5b9d981 into master Apr 30, 2025
2 of 3 checks passed
@nammn nammn deleted the license-mck branch April 30, 2025 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

5 participants

@nammn @MaciejKaras @dan-mckean @vinilage