don't rely on version_id magic

[nammn]

Summary

This pull request updates the tagging scheme in the inventory.yaml file to replace the version_id parameter with the version parameter for consistency and clarity across all image tags. The changes affect multiple sections of the file, ensuring uniformity in how image tags are generated.

version_id is a evergreen magic env which sonar magically picks up and puts into inventory. Therefore we had those weird tags. This magic is not required anymore - since we pass version on every image creation ourselves:

mongodb-kubernetes/pipeline.py

Lines 265 to 278 in 7566a39

	def get_git_release_tag() -> str:
	"""Returns the git tag of the current run on releases, on non-release returns the patch id."""
	release_env_var = os.getenv("triggered_by_git_tag")
	# that means we are in a release and only return the git_tag; otherwise we want to return the patch_id
	# appended to ensure the image created is unique and does not interfere
	if release_env_var is not None:
	logger.info(f"git tag detected: {release_env_var}")
	return release_env_var
	patch_id = os.environ.get("version_id", "latest")
	logger.info(f"No git tag detected, using patch_id: {patch_id}")
	return patch_id

. Additionally, operator was the only leftover where we still used that version_id

Proof of Work

• passing ci image build

Checklist

• Have you linked a jira ticket and/or is the ticket in the title?
• Have you checked whether your jira ticket required DOCSP changes?
• Have you checked for release_note changes?

Reminder (Please remove this when merging)

• Please try to Approve or Reject Changes the PR, keep PRs in review as short as possible
• Our Short Guide for PRs: Link
• Remember the following Communication Standards - use comment prefixes for clarity:
  • blocking: Must be addressed before approval.
  • follow-up: Can be addressed in a later PR or ticket.
  • q: Clarifying question.
  • nit: Non-blocking suggestions.
  • note: Side-note, non-actionable. Example: Praise
  • --> no prefix is considered a question