Skip to content

agent release - add traces #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 4, 2025
Merged

agent release - add traces #226

merged 3 commits into from
Jul 4, 2025

Conversation

nammn
Copy link
Collaborator

@nammn nammn commented Jul 4, 2025

Summary

We sometimes run into errors and having these traced makes it easier to know which ones have failed for later analysis.

This pull request enhances the queue_exception_handling function in pipeline.py by integrating OpenTelemetry tracing and adding detailed metrics to improve observability of task queue error processing.

Observability Enhancements:

  • Added OpenTelemetry tracing to queue_exception_handling
  • Introduced metrics to track task queue processing, including:
    • Total number of tasks (mck.agent.queue.tasks_total).
    • Count of tasks with exceptions (mck.agent.queue.exceptions_count).
    • Success rate of tasks (mck.agent.queue.success_rate).
    • Types of exceptions encountered (mck.agent.queue.exception_types).
    • Boolean flag indicating if exceptions were found (mck.agent.queue.has_exceptions)
  • Updated logging to provide more granular details about exceptions encountered in the task queue

Proof of Work

Checklist

  • Have you linked a jira ticket and/or is the ticket in the title?
  • Have you checked whether your jira ticket required DOCSP changes?
  • Have you checked for release_note changes?

Reminder (Please remove this when merging)

  • Please try to Approve or Reject Changes the PR, keep PRs in review as short as possible
  • Our Short Guide for PRs: Link
  • Remember the following Communication Standards - use comment prefixes for clarity:
    • blocking: Must be addressed before approval.
    • follow-up: Can be addressed in a later PR or ticket.
    • q: Clarifying question.
    • nit: Non-blocking suggestions.
    • note: Side-note, non-actionable. Example: Praise
    • --> no prefix is considered a question
@anandsyncs anandsyncs marked this pull request as ready for review July 4, 2025 12:59
@anandsyncs anandsyncs requested a review from a team as a code owner July 4, 2025 12:59
@nammn nammn enabled auto-merge (squash) July 4, 2025 13:41
@nammn nammn merged commit 4aca390 into master Jul 4, 2025
19 of 21 checks passed
@nammn nammn deleted the add-agent-error-traces branch July 4, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants