Skip to content

Use operator name from env var for webhook setup #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 9, 2025
Merged

Use operator name from env var for webhook setup #222

merged 1 commit into from
Jul 9, 2025

Conversation

@m1kola
Copy link
Contributor

@m1kola m1kola commented Jul 2, 2025

Summary

No need to hardcode operator name as we can determine it from the env var we already pass to the operator.

Proof of Work

CI must be green.

Checklist

  • Have you linked a jira ticket and/or is the ticket in the title?
  • Have you checked whether your jira ticket required DOCSP changes?
  • Have you checked for release_note changes?

Reminder (Please remove this when merging)

  • Please try to Approve or Reject Changes the PR, keep PRs in review as short as possible
  • Our Short Guide for PRs: Link
  • Remember the following Communication Standards - use comment prefixes for clarity:
    • blocking: Must be addressed before approval.
    • follow-up: Can be addressed in a later PR or ticket.
    • q: Clarifying question.
    • nit: Non-blocking suggestions.
    • note: Side-note, non-actionable. Example: Praise
    • --> no prefix is considered a question
@m1kola m1kola marked this pull request as ready for review July 3, 2025 07:42
@m1kola m1kola requested a review from a team as a code owner July 3, 2025 07:42
lucian-tosa
lucian-tosa approved these changes Jul 4, 2025
View reviewed changes
Copy link
Contributor

@lucian-tosa lucian-tosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice finding, LGTM
@m1kola m1kola merged commit 2571d04 into mongodb:master Jul 9, 2025
35 checks passed
@m1kola m1kola deleted the use_operator_name_from_env branch July 9, 2025 08:42
m1kola added a commit to m1kola/mongodb-kubernetes that referenced this pull request Jul 11, 2025
@m1kola
Add a default value for OPERATOR_NAME env var
5773b42 
In mongodb#222 we made `OPERATOR_NAME` env var required and it breaks local development workflows. This chagne adds default values for `OPERATOR_NAME` env vars into appropriate context files.
m1kola added a commit to m1kola/mongodb-kubernetes that referenced this pull request Jul 11, 2025
@m1kola
Add a default value for OPERATOR_NAME env var
e4bd016 
In mongodb#222 we made `OPERATOR_NAME` env var required and it breaks local development workflows. This change adds a default value for `OPERATOR_NAME` env var into appropriate context files.
m1kola added a commit to m1kola/mongodb-kubernetes that referenced this pull request Jul 11, 2025
@m1kola
Add a default value for OPERATOR_NAME env var
2937fea 
In mongodb#222 we made `OPERATOR_NAME` env var required and it breaks local development workflows. This change adds a default value for `OPERATOR_NAME` env var into appropriate context files.
@m1kola m1kola mentioned this pull request Jul 11, 2025
Merged
3 tasks
m1kola added a commit that referenced this pull request Jul 11, 2025
@m1kola
Add a default value for OPERATOR_NAME env var (#248)
8a8ddc1 
In #222 we made `OPERATOR_NAME` env var required and it breaks local development workflows. This change adds a default value for `OPERATOR_NAME` env var into appropriate context files.
viveksinghggits added a commit that referenced this pull request Jul 15, 2025
@viveksinghggits
Add OPERATOR_NAME env var in .generated files for operator
f79c35e 
As part of one of the recent changes #222 we added a new env var OPERATOR_NAME. After switching the context this env var was correctly populated in the generated files `context.env` and `context.export.env` but it was not being populated in the other generated files (`context.operator.env` and `context.operator.export.env`). This commit fixes that.
@viveksinghggits viveksinghggits mentioned this pull request Jul 15, 2025
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@m1kola @anandsyncs @lucian-tosa