Fix configure_docker_auth Evergreen credentials caching #137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nammn approved these changes May 20, 2025
mircea-cosbuc approved these changes May 20, 2025
mircea-cosbuc pushed a commit that referenced this pull request May 21, 2025
# Summary `configure_docker_auth.sh` should only try to skip logging in when not running on Evergreen, according to its comments, but the shell script condition was inverted to only enable the early exit on Evergreen, not locally. This now causes issues on Evergreen where preceding runs might have left stale quay.io registry credentials. Always configuring docker auth on CI ensures that our credentials override any stale ones. ## Proof of Work No CI tasks output `Docker credentials are up to date - not performing the new login!`. ## Checklist - [ ] Have you linked a jira ticket and/or is the ticket in the title? - [ ] Have you checked whether your jira ticket required DOCSP changes? - [ ] Have you checked for release_note changes? ## Reminder (Please remove this when merging) - Please try to Approve or Reject Changes the PR, keep PRs in review as short as possible - Our Short Guide for PRs: [Link](https://docs.google.com/document/d/1T93KUtdvONq43vfTfUt8l92uo4e4SEEvFbIEKOxGr44/edit?tab=t.0) - Remember the following Communication Standards - use comment prefixes for clarity: * **blocking**: Must be addressed before approval. * **follow-up**: Can be addressed in a later PR or ticket. * **q**: Clarifying question. * **nit**: Non-blocking suggestions. * **note**: Side-note, non-actionable. Example: Praise * --> no prefix is considered a question
mircea-cosbuc added a commit that referenced this pull request May 21, 2025
…137) (#145) # Summary `configure_docker_auth.sh` should only try to skip logging in when not running on Evergreen, according to its comments, but the shell script condition was inverted to only enable the early exit on Evergreen, not locally. This now causes issues on Evergreen where preceding runs might have left stale quay.io registry credentials. Always configuring docker auth on CI ensures that our credentials override any stale ones. ## Proof of Work No CI tasks output `Docker credentials are up to date - not performing the new login!`. ## Checklist - [ ] Have you linked a jira ticket and/or is the ticket in the title? - [ ] Have you checked whether your jira ticket required DOCSP changes? - [ ] Have you checked for release_note changes? ## Reminder (Please remove this when merging) - Please try to Approve or Reject Changes the PR, keep PRs in review as short as possible - Our Short Guide for PRs: [Link](https://docs.google.com/document/d/1T93KUtdvONq43vfTfUt8l92uo4e4SEEvFbIEKOxGr44/edit?tab=t.0) - Remember the following Communication Standards - use comment prefixes for clarity: * **blocking**: Must be addressed before approval. * **follow-up**: Can be addressed in a later PR or ticket. * **q**: Clarifying question. * **nit**: Non-blocking suggestions. * **note**: Side-note, non-actionable. Example: Praise * --> no prefix is considered a question # Summary <!-- Enter your issue summary here.--> ## Proof of Work <!-- Enter your proof that it works here.--> ## Checklist - [ ] Have you linked a jira ticket and/or is the ticket in the title? - [ ] Have you checked whether your jira ticket required DOCSP changes? - [ ] Have you checked for release_note changes? ## Reminder (Please remove this when merging) - Please try to Approve or Reject Changes the PR, keep PRs in review as short as possible - Our Short Guide for PRs: [Link](https://docs.google.com/document/d/1T93KUtdvONq43vfTfUt8l92uo4e4SEEvFbIEKOxGr44/edit?tab=t.0) - Remember the following Communication Standards - use comment prefixes for clarity: * **blocking**: Must be addressed before approval. * **follow-up**: Can be addressed in a later PR or ticket. * **q**: Clarifying question. * **nit**: Non-blocking suggestions. * **note**: Side-note, non-actionable. Example: Praise * --> no prefix is considered a question Co-authored-by: Yavor Georgiev <fealebenpae@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Summary
configure_docker_auth.shshould only try to skip logging in when not running on Evergreen, according to its comments, but the shell script condition was inverted to only enable the early exit on Evergreen, not locally.This now causes issues on Evergreen where preceding runs might have left stale quay.io registry credentials. Always configuring docker auth on CI ensures that our credentials override any stale ones.
Proof of Work
No CI tasks output
Docker credentials are up to date - not performing the new login!.Checklist
Reminder (Please remove this when merging)