Skip to content

WIP: Rename --include to --image and remove build_all_images func #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 6 commits into
base: simon/remove-unused-params
Choose a base branch
from
Draft

WIP: Rename --include to --image and remove build_all_images func #132

wants to merge 6 commits into from

Conversation

SimonBaeumer
Copy link
Member

Summary

Rename --include to --image and remove build_all_images func

Proof of Work

  • CI pipeline builds images

Checklist

  • Have you linked a jira ticket and/or is the ticket in the title?
  • Have you checked whether your jira ticket required DOCSP changes?
  • Have you checked for release_note changes?

Reminder (Please remove this when merging)

  • Please try to Approve or Reject Changes the PR, keep PRs in review as short as possible
  • Our Short Guide for PRs: Link
  • Remember the following Communication Standards - use comment prefixes for clarity:
    • blocking: Must be addressed before approval.
    • follow-up: Can be addressed in a later PR or ticket.
    • q: Clarifying question.
    • nit: Non-blocking suggestions.
    • note: Side-note, non-actionable. Example: Praise
    • --> no prefix is considered a question
@SimonBaeumer SimonBaeumer mentioned this pull request May 16, 2025
Open
MaciejKaras
MaciejKaras approved these changes May 16, 2025
View reviewed changes
Copy link
Collaborator

@MaciejKaras MaciejKaras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! :)
@SimonBaeumer SimonBaeumer force-pushed the simon/remove-unused-params branch from e69f976 to 3753163 Compare June 13, 2025 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@SimonBaeumer @MaciejKaras