chore(config): remove kustomize deprecations #1362
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
kustomize v3 deprecated the use of bases, and resources field inherits its responsibility. Signed-off-by: Massimiliano Giovagnoli <me@maxgio.it>
maxgio92 requested review from irajdeep, lsierant, mircea-cosbuc, nammn and slaskawi as code owners 
irajdeep added the safe-to-test 
| LGTM. Thanks! |
irajdeep approved these changes Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR removes a deprecation in two kustomizations, where the field kustomize v2's
basesfield was still used.From the version 3
resourcesreplaces both usages of child kustomizations and bases kustomizations located outside of the user kustomization directory, becoming agnostic to the location of kustomizations, and their resources are accumulated the same way.Additional context
Furthermore, kustomize v3 is already two major versions behind the current stable one (v5).
There are already users of the latter version, for example,
kubectlv1.27 comes with the embedded kustomize v5.0.1.Unrelated to the previous point, it seems that no
operator-sdk generate kustomize manifestsautomated run is present in the codebase, and the kustomizations are not automatically generated, right now.Open issues
Closes #1355
All Submissions:
closes #XXXXin your comment to auto-close the issue that your PR fixes (if such).