PYTHON-2798 Workaround windows cert issue with SSL_CERT_FILE #670
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Note that the Windows 3.10 failures are expected. |
| patcher = None | ||
| | ||
| | ||
| def setUpModule(): |
There was a problem hiding this comment.
Is this a standard interface expected by unittest?
There was a problem hiding this comment.
Also, why is this needed if we can just call self.patch_system_certs wherever required?
There was a problem hiding this comment.
Yes. https://docs.python.org/3/library/unittest.html#setupmodule-and-teardownmodule
It was easier to implement this for the entire module than it was to try do it via setUpClass() or setUp().
prashantmital approved these changes Jul 12, 2021
ShaneHarvey added a commit to ShaneHarvey/mongo-python-driver that referenced this pull request Jul 12, 2021
ShaneHarvey added a commit that referenced this pull request Jul 12, 2021
(cherry picked from commit 6d1ebf4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Apparently SSL_CERT_FILE does work on Windows. We can use it to workaround the issue in BUILD-13574.