Fix issues found by coverity #377
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| That's interesting. We run coverity also, but don't get any output related to pure Python, only the C extensions. Thanks for this. We'll take a deeper look soon. |
ShaneHarvey pushed a commit that referenced this pull request Dec 14, 2018
| Merged thanks @omron93! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I've run coverity scan of python-pymongo 3.6.1 - see log scan-results.txt
I've guessed what is the right way to fix the issues which IMHO aren't false positive. In case of other preferences, I will change it.
pymongo/database.py- without this fix,elifis never reached.mongo_client.py-sessioncan be None, so it needs to be checked.test_cursor.py- typoutils.py- currently `pref.tag_sets" is never used. Using tags from both lists.