Skip to content

Conversation

@ShaneHarvey
Copy link
Member

There's no need to project out the _id field in this test. I opened SERVER-36598 for the server bug.

@prashantmital
Copy link
Contributor

Can we project out some other field instead (doesn't have to be _id). Projecting out a subset of the entire document seems to test an additional code-path here and we might be losing that with this change?

@ShaneHarvey
Copy link
Member Author

There's no difference in codepath because PyMongo doesn't don't do anything special with the pipeline. It just passes it along to the server. So adding a $project would just add unnecessary noise.

Copy link
Contributor

@prashantmital prashantmital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

@ShaneHarvey ShaneHarvey merged commit 5bc0c70 into mongodb:master Aug 10, 2018
@ShaneHarvey ShaneHarvey deleted the PYTHON-1624 branch August 10, 2018 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants