PYTHON-1603 Truncate large datetimes properly #362
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ShaneHarvey commented Jul 9, 2018
| dtm = dtm - dtm.utcoffset() | ||
| return int(calendar.timegm(dtm.timetuple()) * 1000 + | ||
| dtm.microsecond / 1000) | ||
| dtm.microsecond // 1000) |
There was a problem hiding this comment.
Should line 822 also use // in seconds = (millis - diff) / 1000 ?
ShaneHarvey commented Jul 9, 2018
| dt1 = datetime.datetime(9999, 1, 1, 1, 1, 1, 999999) | ||
| dt2 = BSON.encode({"date": dt1}).decode()["date"] | ||
| self.assertEqual(dt2.microsecond, 999000) | ||
| self.assertEqual(dt2.second, dt1.second) |
There was a problem hiding this comment.
I can reproduce this on Windows with 32-bit and 64-bit Python 3.X. So this fix does actually work.
behackett approved these changes Jul 9, 2018
ShaneHarvey added a commit to ShaneHarvey/mongo-python-driver that referenced this pull request Jul 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.