Skip to content

PYTHON-5094 - Convert test.test_read_preferences to async #2110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 5, 2025
Merged

PYTHON-5094 - Convert test.test_read_preferences to async #2110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4a1f7ab
PYTHON-5094 - Convert test.test_read_preferences to async
NoahStapp Jan 31, 2025
0dfb262
Merge branch 'master' into PYTHON-5094
NoahStapp Jan 31, 2025
c228769
Fix to_list typo
NoahStapp Jan 31, 2025
c5d5d17
Merge branch 'master' into PYTHON-5094
NoahStapp Feb 3, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -593,7 +593,7 @@ def supports_secondary_read_pref(self):
if self.has_secondaries:
return True
if self.is_mongos:
shard = self.client.config.shards.find_one()["host"] # type:ignore[index]
shard = (self.client.config.shards.find_one())["host"] # type:ignore[index]
num_members = shard.count(",") + 1
return num_members > 1
return False
Expand Down
4 changes: 2 additions & 2 deletions test/asynchronous/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -592,10 +592,10 @@ async def check():

@property
async def supports_secondary_read_pref(self):
if self.has_secondaries:
if await self.has_secondaries:
return True
if self.is_mongos:
shard = await self.client.config.shards.find_one()["host"] # type:ignore[index]
shard = (await self.client.config.shards.find_one())["host"] # type:ignore[index]
num_members = shard.count(",") + 1
return num_members > 1
return False
Expand Down
Loading
Loading