PYTHON-3366 Support mypy 0.971 and test with latest version #1021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ShaneHarvey commented Jul 22, 2022
| return cls(encode(document, check_keys, codec_options)) | ||
| | ||
| def decode(self, codec_options: CodecOptions = DEFAULT_CODEC_OPTIONS) -> _DocumentType: # type: ignore[override] | ||
| def decode(self, codec_options: "CodecOptions[_DocumentType]" = DEFAULT_CODEC_OPTIONS) -> _DocumentType: # type: ignore[override,assignment] |
There was a problem hiding this comment.
The "assignment" ignore is required to silence this error:
bson/__init__.py: note: In member "decode" of class "BSON": bson/__init__.py:1311: error: Incompatible default for argument "codec_options" (default has type "CodecOptions[MutableMapping[str, Any]]", argument has type "CodecOptions[_DocumentType]") [assignment] def decode(self, codec_options: "CodecOptions[_DocumentType]" = DEFAULT_CODEC_OPTIONS) -> _DocumentType: # type: ignore[override] pymongo/pyopenssl_context.py Outdated
| # server side sockets. | ||
| self._callback_data.check_ocsp_endpoint = True | ||
| self._ctx.set_ocsp_client_callback(callback=_ocsp_callback, data=self._callback_data) | ||
| self._ctx.set_ocsp_client_callback(callback=_ocsp_callback, data=self._callback_data) # type: ignore[arg-type] |
There was a problem hiding this comment.
This ignore is required until python/typeshed#8371 is fixed and released.
| The remaining errors are in the tests and look like: Looks like a mypy bug. I'm not sure why it considers these types are incompatible. Perhaps "_DocumentType" is incompatible with "object"? I believe this is a typeshed bug that will be fixed by: python/typeshed#8373 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/PYTHON-3366
Changes: