Skip to content

Conversation

GromNaN
Copy link
Member

@GromNaN GromNaN commented Feb 7, 2025

.gitmodules Outdated
@@ -1,3 +1,6 @@
[submodule "drivers-tools"]
path = tests/drivers-tools
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realize we use this for both Evergreen and GitHub CI, but would it be preferable to keep the path consistent with the repository name?

@GromNaN GromNaN force-pushed the PHPLIB-1613 branch 2 times, most recently from bef4a4c to 3af5416 Compare February 7, 2025 19:19
@GromNaN GromNaN marked this pull request as ready for review February 7, 2025 19:28
@GromNaN GromNaN requested a review from a team as a code owner February 7, 2025 19:28
@GromNaN GromNaN requested review from alcaeus and jmikola February 7, 2025 19:28
@GromNaN
Copy link
Member Author

GromNaN commented Feb 7, 2025

I think there is a configuration of dependabot to do to ensure we get distinct PR for each submodule. The solution might be to create groups: https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/optimizing-pr-creation-version-updates

@GromNaN
Copy link
Member Author

GromNaN commented Feb 10, 2025

I'm merging the PR as the last dependabot PR #1587 is failing and I suspect the commit mongodb-labs/drivers-evergreen-tools@31d5280

We will figure the best dependabot configuration in an other PR.

@GromNaN GromNaN merged commit e25fafa into mongodb:v1.x Feb 10, 2025
31 checks passed
This was referenced Feb 10, 2025
paulinevos added a commit to paulinevos/mongo-php-library that referenced this pull request Aug 26, 2025
As it seems to be covered by the `drivers-evergreen-tools` submodule, which is loaded in evergreen functions and GH actions (added in PR `mongodb#1584`)
paulinevos added a commit that referenced this pull request Aug 27, 2025
* Remove `.evergreen/ocsp` directory As it seems to be covered by the `drivers-evergreen-tools` submodule, which is loaded in evergreen functions and GH actions (added in PR `#1584`) * Clean up `.evergreen/orchestration` directory Its contents don't seem to be used * Clean up `.evergreen/auth_aws` It doesn't appear to be referenced locally anymore, only internally in the drivers-evergreen-tools submodule * Clean up`.evergreen/x509gen` directory There's no need for it locally as it's covered by the `drivers-everygreen-tools` submodule
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants