Add namespace type support to ChangeStreamDocument. #1736
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
vbabanin commented Jun 10, 2025
Comment on lines +361 to +364
| /** | ||
| * Not a prose spec test. However, it is additional test case for better coverage. | ||
| */ | ||
| @Test |
Member Author
There was a problem hiding this comment.
Unified tests validate the raw BsonDocument returned from a MongoCursor, while these prose tests add additional integration coverage for working with ChangeStreamDocument.
vbabanin requested review from a team and katcharov and removed request for a team 
katcharov approved these changes Jun 11, 2025
driver-core/src/main/com/mongodb/client/model/changestream/ChangeStreamDocument.java Show resolved Hide resolved
driver-core/src/main/com/mongodb/client/model/changestream/OperationType.java Show resolved Hide resolved
jyemin reviewed Jun 16, 2025
Collaborator
jyemin left a comment
jyemin left a comment There was a problem hiding this comment.
Just noticed that ChangeStreamDocumentCodec#OPERATION_TYPE_CODEC is unused and so OperationTypeCodec is dead code. Should we remove both (in this PR or a subsequent one)?
Member Author
Good catch! I crated a separate PR for removing unused codec: #1746 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
JAVA-5769