Skip to content

Gradle: Ensure maven artifacts are signed. #1709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 6, 2025
Merged

Gradle: Ensure maven artifacts are signed. #1709

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d19cffd
Version: bump 5.5.0
katcharov May 5, 2025
f17ece8
Version: bump 5.5.1-SNAPSHOT
katcharov May 5, 2025
3c8e560
Gradle: Ensure maven artifacts are signed.
rozza May 6, 2025
07ca9ea
PR update
rozza May 6, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Gradle: Ensure maven artifacts are signed. 
Log a warning if the signing keys are missing. JAVA-5872
  • Loading branch information
@rozza
rozza committed May 6, 2025
commit 3c8e560959badb74c7c256eb1bcf22fc16f40f84
3 changes: 3 additions & 0 deletions buildSrc/src/main/kotlin/conventions/publishing.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,9 @@ signing {
if (signingKey.isPresent && signingPassword.isPresent) {
logger.debug("[${project.displayName}] Signing is enabled")
useInMemoryPgpKeys(signingKey.get(), signingPassword.get())
sign(publishing.publications["maven"])
} else {
logger.warn("[${project.displayName}] No Signing keys found, skipping signing configuration")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make both the logging statements info, since it's normal to publish to the local repository without signing, and Sonatype won't let us release without signatures anyway.
}
}

Expand Down