Improve selection criteria for srvMaxHosts #1590
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
joykim1005 requested review from a team and stIncMale and removed request for a team 
| I removed @stIncMale since he is currently overloaded. @katcharov please let me know if you think a second reviewer is needed for this. |
katcharov requested changes Jan 11, 2025
driver-core/src/main/com/mongodb/internal/connection/DnsMultiServerCluster.java Outdated Show resolved Hide resolved
driver-core/src/main/com/mongodb/internal/connection/DnsMultiServerCluster.java Outdated Show resolved Hide resolved
driver-core/src/main/com/mongodb/internal/connection/DnsMultiServerCluster.java Outdated Show resolved Hide resolved
driver-core/src/main/com/mongodb/internal/connection/DnsMultiServerCluster.java Outdated Show resolved Hide resolved
driver-core/src/main/com/mongodb/internal/connection/DnsMultiServerCluster.java Outdated Show resolved Hide resolved
driver-core/src/main/com/mongodb/internal/connection/DnsMultiServerCluster.java Outdated Show resolved Hide resolved
driver-core/src/main/com/mongodb/internal/connection/DnsMultiServerCluster.java Outdated Show resolved Hide resolved
katcharov approved these changes Jan 14, 2025
driver-core/src/main/com/mongodb/internal/connection/DnsMultiServerCluster.java Outdated Show resolved Hide resolved
driver-core/src/main/com/mongodb/internal/connection/DnsMultiServerCluster.java Outdated Show resolved Hide resolved
driver-core/src/main/com/mongodb/internal/connection/DnsMultiServerCluster.java Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Ticket
JAVA-4400
Description
This PR improves the selection criteria for srvMaxHosts. The net result is that it will keep existing nodes, discard deleted nodes, and fill up to srvMaxHosts from a random shuffle of newly discovered nodes from the SRV response. It also updates the prose test to match the spec.
Testing