Remove support for MongoDB 3.6 #1375
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
* Remove branching code in the driver based on 3.6 version checks * Remove testing of 3.5 * Clean up tests JAVA-5294
rozza approved these changes May 2, 2024
driver-sync/src/test/functional/com/mongodb/client/AbstractExplainTest.java Show resolved Hide resolved
| @rozza in my final checks before merging I found a few more places that needed updating |
jyemin commented May 2, 2024
driver-core/src/main/com/mongodb/internal/operation/ServerVersionHelper.java Show resolved Hide resolved
jyemin commented May 2, 2024
driver-core/src/main/com/mongodb/internal/connection/CommandMessage.java Show resolved Hide resolved
rozza reviewed May 2, 2024
| import static com.mongodb.connection.ClusterConnectionMode.MULTIPLE | ||
| import static com.mongodb.connection.ClusterConnectionMode.SINGLE | ||
| import static com.mongodb.internal.operation.ServerVersionHelper.LATEST_WIRE_VERSION | ||
| import static com.mongodb.internal.operation.ServerVersionHelper.THREE_DOT_SIX_WIRE_VERSION |
There was a problem hiding this comment.
Is ServerVersionHelper.THREE_DOT_SIX_WIRE_VERSION needed anymore?
There was a problem hiding this comment.
It was just used in a few tests, so I replaced all usages with LATEST_WIRE_VERSION and removed it.
rozza reviewed May 3, 2024
driver-core/src/main/com/mongodb/internal/operation/ServerVersionHelper.java Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
JAVA-5294
Let me know if I was too aggressive on the test cleanup. None of it is strictly necessary, but it feels tidier.