Force unique clusterTime values by splitting insert into two commands #1356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
jyemin commented Apr 1, 2024
| // write operation, and the test relies on the clusterTime values being both ascending _and_ unique. | ||
| def expectedOne = insertDocuments(helper, [1]) | ||
| def expectedTwo = insertDocuments(helper, [2]) | ||
| def expected = [] |
There was a problem hiding this comment.
I'm sure there is a more idiomatic one liner that will do this but I didn't think it was important enough to research. :)
katcharov approved these changes Apr 2, 2024
...src/test/functional/com/mongodb/internal/operation/ChangeStreamOperationSpecification.groovy Outdated Show resolved Hide resolved
rozza approved these changes Apr 2, 2024
…/ChangeStreamOperationSpecification.groovy Co-authored-by: Maxim Katcharov <maxim.katcharov@mongodb.com>
jyemin added a commit that referenced this pull request Apr 2, 2024
jyemin added a commit that referenced this pull request Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
JAVA-5397