drivertest: name an anonymous error #2115
Merged
+5 −1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
mongodb-drivers-pr-bot bot added the review-priority-low 
API Change Report./v2/x/mongo/driver/drivertestcompatible changesErrNoResponsesRemaining: added |
mmcclimon force-pushed the drivertest-named-error branch from c81b372 to 1154581 Compare 
This makes it slightly easier for downstream users to check for this error specifically.
mmcclimon force-pushed the drivertest-named-error branch from 1154581 to e20ed46 Compare 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Summary
This makes it slightly easier for downstream users to check for this error specifically.
Background & Motivation
We currently have a custom implementation of MockDeployment that was more-or-less copied from the v1 Go driver. I would like to replace that with the new-in-v2 drivertest package, and having this be a named error instead of an anonymous one would make some of our downstream code a bit easier to write.