CXX-2710 Run microbenchmarks in Evergreen #1063
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
eramongodb reviewed Nov 27, 2023
Co-authored-by: Ezra Chung <88335979+eramongodb@users.noreply.github.com>
eramongodb approved these changes Dec 11, 2023
Contributor
eramongodb left a comment
eramongodb left a comment There was a problem hiding this comment.
Minor suggestions; otherwise, LGTM.
* Add forward headers to clang-format rules * Add forward headers for bsoncxx and mongocxx * Make using namespace declaration in list.hpp VERY noticable * Ensure headers provide the definitive declaration for all entities (no rogue forward declarations). * Use simple-type-specifier form for friend class declarations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Passing run: https://spruce.mongodb.com/version/6564e561a4cf47858456d6fc