CDRIVER-6102 use mn for minutes suffix #2148
Merged
+15 −6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
To avoid conflict with commonly defined `min` macro.
rcsanchez97 approved these changes Oct 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Summary
Use
mn(notmin) for minutes suffixBackground & Motivation
Working on CDRIVER-6102 encountered a compile error defining a duration of minutes:
This was caused by
minalready being defined as a macro. A longer-term improvement may be to guard macros in every source file (similar to the C++ driver). This PR proposes a simpler short-term solution by renaming frommintomnsinceminis a commonly defined macro.