- Notifications
You must be signed in to change notification settings - Fork 1.5k
PHPORM-146: Add override attribute everywhere #3412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Apparently |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is huge, and will be very helpful to detect when a parent method is removed.
I spotted some tiny changes.
We squash-merge. So you can refine the commit message in the merge box in GitHub. |
d5e0610
to 99ea95c
Compare da2f424
to 5c296f9
Compare to keep track of the methods we're overriding on the base builder
5c296f9
to 51526a5
Compare Would it make sense to enable the |
Some methods are added in newer versions of Laravel, and are not available in Laravel 9, 10 or 11.0. |
Is there a way we can actually do that? I can only find a parameter for the PHP version in the phpstan docs, but nothing about a specific version of a dependency/Laravel in either the phpstan or larastan docs |
51526a5
to 65b0b21
Compare 65b0b21
to 9b6b30b
Compare
Closes PHPORM-146
Adds the override attribute in every class that extends a Laravel base class, so that PHP will show errors if ever the base methods are renamed or removed.
Also adds in a few corrections to phpdoc declarations where necessary.
Checklist
Add tests and ensure they pass(not applicable)