v1.68.0 #152
Merged
v1.68.0 #152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in Bitbucket authenticated cloning by allowing token-only authentication without requiring a username. The change ensures that KF_BITBUCKET_TOKEN alone is sufficient for git operations using x-token-auth.
Key Changes:
- Added fallback authentication path for token-only Bitbucket authentication
- Updated credential checking logic to include
bitbucket_token - Simplified documentation to reflect that username is no longer required for Workspace API tokens
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/git_binary.rs | Added token-only authentication fallback and updated credential checking logic; includes comprehensive test coverage |
| README.md | Removed requirement for KF_BITBUCKET_USERNAME when using Workspace API token |
| Cargo.toml | Version bump to 1.68.0 |
| CHANGELOG.md | Added release notes for v1.68.0 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
README.md Outdated
| - **Workspace API token (Cloud)** – set `KF_BITBUCKET_TOKEN`. `KF_BITBUCKET_USERNAME` | ||
| is optional; Kingfisher automatically uses the token for Bitbucket REST APIs | ||
| and authenticates git operations as `x-token-auth`. | ||
| - **Workspace API token (Cloud)** – set `KF_BITBUCKET_TOKEN`.Kingfisher automatically uses the token for Bitbucket REST APIs and authenticates git operations as `x-token-auth`. |
There was a problem hiding this comment.
Missing space after period. Should be 'KF_BITBUCKET_TOKEN`. Kingfisher' with a space between the period and 'Kingfisher'.
Suggested change
| - **Workspace API token (Cloud)** – set `KF_BITBUCKET_TOKEN`.Kingfisher automatically uses the token for Bitbucket REST APIs and authenticates git operations as `x-token-auth`. | |
| - **Workspace API token (Cloud)** – set `KF_BITBUCKET_TOKEN`. Kingfisher automatically uses the token for Bitbucket REST APIs and authenticates git operations as `x-token-auth`. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixed Bitbucket authenticated cloning bug