v1.62.0 #141
v1.62.0 #141
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes CI builds for Windows on GitHub Actions by refactoring the vcpkg setup logic and adding a Windows CI job. The main changes centralize vcpkg installation handling, improve caching configuration, and ensure consistent behavior across CI and release workflows.
Key changes:
- Refactored
buildwin.batto use a reusable subroutine for vcpkg installation - Updated vcpkg cache configuration to use a static key and include additional cache paths
- Added Windows x64 CI job with test execution using cargo-nextest
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
buildwin.bat | Extracted inline vcpkg setup logic into :ensure_vcpkg subroutine and centralized VCPKG_ROOT variable |
.github/workflows/release.yml | Updated vcpkg cache paths/key and removed -force flag from build command |
.github/workflows/ci.yml | Added complete Windows CI job with vcpkg caching, build, and test steps |
data/rules/aws.yml | Added word boundary marker to AWS secret detection pattern |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
data/rules/aws.yml Outdated
| ([A-Za-z0-9/+]{40}) | ||
| \b | ||
| ) | ||
| \b |
There was a problem hiding this comment.
[nitpick] The addition of \b on line 42 appears to be adding a word boundary to the regex pattern. Consider adding a comment explaining why this boundary is necessary to prevent false positives or clarify the pattern's intent.
| \b | |
| \b # Word boundary to ensure the secret key is matched as a standalone token and prevent false positives. |
.github/workflows/release.yml Outdated
| C:\vcpkg\downloads | ||
| C:\vcpkg\archives | ||
| C:\Users\runneradmin\AppData\Local\vcpkg\archives | ||
| key: ${{ runner.os }}-vcpkg-hyperscan |
There was a problem hiding this comment.
The cache key changed from a content-based hash to a static string 'hyperscan'. This means the cache won't be invalidated when vcpkg dependencies change. Consider including a version identifier or hash to ensure cache invalidation when dependencies are updated.
| key: ${{ runner.os }}-vcpkg-hyperscan | |
| key: ${{ runner.os }}-vcpkg-hyperscan-${{ hashFiles('vcpkg.json', 'vcpkg-lock.json') }} |
.github/workflows/ci.yml Outdated
| C:\vcpkg\downloads | ||
| C:\vcpkg\archives | ||
| C:\Users\runneradmin\AppData\Local\vcpkg\archives | ||
| key: ${{ runner.os }}-vcpkg-hyperscan |
There was a problem hiding this comment.
The cache key is static and won't invalidate when vcpkg dependencies change. Consider including a version identifier or hash to ensure the cache is refreshed when dependencies are updated.
| key: ${{ runner.os }}-vcpkg-hyperscan | |
| key: ${{ runner.os }}-vcpkg-hyperscan-${{ hashFiles('vcpkg.json') }} |
Fixing CI builds for Windows on GitHub Actions