Skip to content

chore(NODE-6382): add benchmarking for helpers #717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 16, 2024
Merged

chore(NODE-6382): add benchmarking for helpers #717

merged 7 commits into from
Sep 16, 2024

Conversation

nbbeeken
Copy link
Contributor

Description

What is changing?

  • Adds a benchmark suite that will output to our trendcharting tool.
Is there new documentation needed for these changes?

No

What is the motivation for this change?

  • There are a number of code paths that don't relate to serialize/deserialize but can still be useful for critical paths in an application. It would be useful to improve those where we can and ensure we maintain the improvements where they are made.
  • Help with the change proposed: perf(NODE-6344): Improve ObjectId.isValid(string) performance #708

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket
@nbbeeken nbbeeken requested a review from W-A-James September 16, 2024 18:23
@nbbeeken nbbeeken added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Sep 16, 2024
W-A-James
W-A-James suggested changes Sep 16, 2024
View reviewed changes
@nbbeeken nbbeeken requested a review from W-A-James September 16, 2024 18:40
W-A-James
W-A-James previously approved these changes Sep 16, 2024
View reviewed changes
@W-A-James W-A-James added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Sep 16, 2024
dariakp
dariakp reviewed Sep 16, 2024
View reviewed changes
@W-A-James W-A-James merged commit 465e8cd into main Sep 16, 2024
8 checks passed
@W-A-James W-A-James deleted the chore-custom-benchmarks branch September 16, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Team Review Needs review from team

3 participants

@nbbeeken @W-A-James @dariakp