Skip to content

Conversation

@W-A-James
Copy link
Contributor

@W-A-James W-A-James commented Mar 14, 2023

Description

What is changing?

Allow for Maps to be stringified using EJSON.stringify

Is there new documentation needed for these changes?

No

Double check the following

  • Ran npm run lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket
@W-A-James W-A-James changed the title fix(NODE-4789): Add fix feat(NODE-4789): Support Map Stringification in EJSON Mar 14, 2023
@W-A-James W-A-James marked this pull request as ready for review March 14, 2023 21:09
Co-authored-by: Anna Henningsen <anna@addaleax.net>
@nbbeeken nbbeeken self-assigned this Mar 15, 2023
@nbbeeken nbbeeken added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Mar 15, 2023
W-A-James and others added 2 commits March 15, 2023 16:45
Co-authored-by: Neal Beeken <neal.beeken@mongodb.com>
@W-A-James W-A-James requested a review from nbbeeken March 15, 2023 20:47
@nbbeeken nbbeeken added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Mar 15, 2023
@nbbeeken nbbeeken changed the title feat(NODE-4789): Support Map Stringification in EJSON feat(NODE-4789): support Map stringification in EJSON Mar 16, 2023
@nbbeeken nbbeeken merged commit c70c82d into main Mar 16, 2023
@nbbeeken nbbeeken deleted the NODE-4789/Support_Map_Stringification_in_EJSON branch March 16, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Team Review Needs review from team

5 participants