Skip to content

test(NODE-4803): add test for toStringTag fallback #521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 28, 2022
Merged

test(NODE-4803): add test for toStringTag fallback #521

merged 3 commits into from
Nov 28, 2022

Conversation

@nbbeeken
Copy link
Contributor

@nbbeeken nbbeeken commented Nov 21, 2022

Description

What is changing?

Adds a test for toStringTag fallback to Object.prototype.toString.call logic.

What is the motivation for this change?

Tests that we don't change the behavior that is carefully crafted for unusual or legacy js systems.

Double check the following

  • Ran npm run lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: <type>(NODE-xxxx)<!>: <description>
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket
@nbbeeken nbbeeken changed the base branch from main to NODE-4440-bump-target November 21, 2022 21:51
@nbbeeken nbbeeken force-pushed the NODE-4803-test-fallback-toStringTag branch from 3efff35 to e4b34eb Compare November 21, 2022 22:25
@nbbeeken nbbeeken changed the title NODE-4803-test-fallback-toStringTag test(NODE-4803): add test for toStringTag fallback Nov 21, 2022
@nbbeeken nbbeeken force-pushed the NODE-4803-test-fallback-toStringTag branch from e4b34eb to e93dfb8 Compare November 22, 2022 15:09
Base automatically changed from NODE-4440-bump-target to main November 22, 2022 19:24
@nbbeeken nbbeeken force-pushed the NODE-4803-test-fallback-toStringTag branch from e93dfb8 to a244206 Compare November 22, 2022 19:26
@nbbeeken nbbeeken marked this pull request as ready for review November 22, 2022 19:26
@dariakp dariakp added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Nov 23, 2022
dariakp
dariakp requested changes Nov 23, 2022
View reviewed changes
dariakp
dariakp requested changes Nov 23, 2022
View reviewed changes
Copy link
Contributor

@dariakp dariakp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a happy path test, too
dariakp
dariakp previously approved these changes Nov 23, 2022
View reviewed changes
@dariakp dariakp added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Nov 23, 2022
@nbbeeken nbbeeken force-pushed the NODE-4803-test-fallback-toStringTag branch from eff98bc to 7a84bb4 Compare November 28, 2022 20:32
@dariakp dariakp merged commit 9c6a4b3 into main Nov 28, 2022
@dariakp dariakp deleted the NODE-4803-test-fallback-toStringTag branch November 28, 2022 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Team Review Needs review from team

3 participants

@nbbeeken @dariakp