Skip to content

Remove unused **extra_context from Aggregates, Add EmbeddedModelArrayFieldTransform.VIRTUAL_COLUMN_ITERABLE #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 11, 2025
Merged

Remove unused **extra_context from Aggregates, Add EmbeddedModelArrayFieldTransform.VIRTUAL_COLUMN_ITERABLE #418

merged 2 commits into from
Oct 11, 2025

Conversation

@timgraham
Copy link
Collaborator

cleanups identified in #396
@timgraham timgraham requested a review from WaVEV October 10, 2025 20:46
@timgraham
Copy link
Collaborator Author

@WaVEV I used VIRTUAL_COLUMN_PREFIX instead of PREFIX_ITERABLE since I didn't understand that meaning. Tell me if my interpretation doesn't make sense.
@WaVEV
Copy link
Collaborator

WaVEV commented Oct 10, 2025

@WaVEV I used VIRTUAL_COLUMN_PREFIX instead of PREFIX_ITERABLE since I didn't understand that meaning. Tell me if my interpretation doesn't make sense.

This column represents the iterable used in the map operation over an EMFA. It can refer to a simple column (by name) or to a transform structure (any JSON, EMF, or a combination of both). It’s considered a virtual column since it inherits its field definition from the items being iterated. So the name is ok, PREFIX_ITERABLE is meaningless 🤔 . But what do you think about VIRTUAL_COLUMN_ITERABLE?
@timgraham timgraham changed the title Remove unused **extra_context from Aggregates, Add EmbeddedModelArrayFieldTransform.VIRTUAL_COLUMN_PREFIX Remove unused **extra_context from Aggregates, Add EmbeddedModelArrayFieldTransform.VIRTUAL_COLUMN_ITERABLE Oct 10, 2025
WaVEV
WaVEV reviewed Oct 10, 2025
View reviewed changes
django_mongodb_backend/fields/embedded_model_array.py Outdated
# of the queried field's type represents each element.
column_target = field.clone()
column_name = f"$item.{field.column}"
column_name = f"${self.VIRTUAL_COLUMN_PREFIX}.{field.column}"
Copy link
Collaborator

@WaVEV WaVEV Oct 10, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you forget this?
@timgraham timgraham merged commit af74f95 into mongodb:main Oct 11, 2025
17 checks passed
@timgraham timgraham deleted the agg_unused_context branch October 11, 2025 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@timgraham @WaVEV @blink1073