Skip to content

INTPYTHON-749: Fix bug in null matching on queryoptimizer #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from
Closed

INTPYTHON-749: Fix bug in null matching on queryoptimizer #401

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
6f2052a
Fix bug in null matching on queryoptimizer
Jibola Sep 11, 2025
139d0b4
include none tests for objects.filter
Jibola Sep 11, 2025
fafe479
migrated tests to lookup_ and added data
Jibola Sep 12, 2025
50177bc
call filter once in each test
Jibola Sep 12, 2025
e8011b9
include missing field specifier
Jibola Sep 12, 2025
0ca2a5e
fix field resolution and value lookup
Jibola Sep 12, 2025
4af823a
refactored the tests to remove generics
Jibola Sep 15, 2025
0161dfb
remove the CONSTANT dictionary
Jibola Sep 15, 2025
0b29263
update tests to support ordering and have a default for self.title
Jibola Sep 15, 2025
7802896
added a string safety-check + allowed unordered lists to be compared
Jibola Sep 15, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
call filter once in each test
  • Loading branch information
@Jibola
Jibola committed Sep 12, 2025
commit 50177bc2871fce17e44528d118b755334234f90c
12 changes: 5 additions & 7 deletions tests/lookup_/tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,20 +88,19 @@ def setUpTestData(cls):

def _test_none_filter_nullable_json(self, op, predicate, field):
with self.assertNumQueries(1) as ctx:
list(NullableJSONModel.objects.filter(**{f"{field}__{op}": None}))
self.assertQuerySetEqual(
NullableJSONModel.objects.filter(**{f"{field}__{op}": None}),
[],
)
self.assertAggregateQuery(
ctx.captured_queries[0]["sql"],
"lookup__nullablejsonmodel",
[{"$match": {"$and": [{"$exists": False}, predicate(field)]}}],
)
self.assertQuerySetEqual(
NullableJSONModel.objects.filter(**{f"{field}__{op}": None}),
[],
)

def _test_none_filter_binary_operator(self, op, predicate, field):
with self.assertNumQueries(1) as ctx:
list(Book.objects.filter(**{f"{field}__{op}": None}))
self.assertQuerySetEqual(Book.objects.filter(**{f"{field}__{op}": None}), [])
self.assertAggregateQuery(
ctx.captured_queries[0]["sql"],
"lookup__book",
Expand All @@ -116,7 +115,6 @@ def _test_none_filter_binary_operator(self, op, predicate, field):
}
],
)
self.assertQuerySetEqual(Book.objects.filter(**{f"{field}__{op}": None}), [])

def _test_with_raw_data(self, model, test_function):
collection = connection.database.get_collection(model._meta.db_table)
Expand Down
Loading