Add bump-version and tag-version scripts #32
Conversation
bump-version/action.yml Outdated
| if [ ${{ inputs.dry_run }} != "true" ]; then | ||
| git push origin | ||
| echo "### Version bump: ${{inputs.version}}" >> $GITHUB_STEP_SUMMARY | ||
| else | ||
| echo "### Version bump : ${{inputs.version}}" >> $GITHUB_STEP_SUMMARY | ||
| fi No newline at end of file |
There was a problem hiding this comment.
This can be simplified if you want to print the same message in both cases:
| if [ ${{ inputs.dry_run }} != "true" ]; then | |
| git push origin | |
| echo "### Version bump: ${{inputs.version}}" >> $GITHUB_STEP_SUMMARY | |
| else | |
| echo "### Version bump : ${{inputs.version}}" >> $GITHUB_STEP_SUMMARY | |
| fi | |
| if [ ${{ inputs.dry_run }} != "true" ]; then | |
| git push origin | |
| fi | |
| echo "### Version bump: ${{inputs.version}}" >> $GITHUB_STEP_SUMMARY |
Alternatively, consider using a different message here as you've done in the tag-version action.
bump-version/action.yml Outdated
| dry_run: | ||
| description: Whether this is a dry run | ||
| required: true |
There was a problem hiding this comment.
How about naming this push_commit since that's what it does?
Context: in the PHP repositories, I don't want to push right away since we merge the changes to another branch so our merge-up automation doesn't pick up these changes (as they would conflict anyways)
tag-version/action.yml Outdated
| tag_message_template: | ||
| description: The template for the git tag message | ||
| default: "BUMP ${VERSION}" | ||
| dry_run: |
There was a problem hiding this comment.
Similar to the above, how about naming this push_tag?
bump-version/action.yml Outdated
| - name: Push the commit to the source branch | ||
| shell: bash -eux {0} | ||
| run: | | ||
| if [ ${{ inputs.push_commit }} != "true" ]; then |
There was a problem hiding this comment.
The logic is backwards, resulting in a push when push_commit is set to false ;)
tag-version/action.yml Outdated
| - name: Push the tag to the source branch | ||
| shell: bash -eux {0} | ||
| run: | | ||
| if [ ${{ inputs.push_tag }} != "true" ]; then |
There was a problem hiding this comment.
Same here - the check needs to change
Co-authored-by: Andreas Braun <git@alcaeus.org>
Co-authored-by: Andreas Braun <git@alcaeus.org>
Co-authored-by: Andreas Braun <git@alcaeus.org>
Co-authored-by: Andreas Braun <git@alcaeus.org>
2 participants
Tested with https://github.com/blink1073/winkerberos/actions/runs/9451163300