Skip to content

Conversation

alcaeus
Copy link
Collaborator

@alcaeus alcaeus commented May 8, 2024

Fixes a wrong description and a malfunctioning import of an action relative to the current path: GitHub Actions tries to load the file from the repository it was called from, not relative to the actions repository. To avoid hardcoding branch names or the repository name, I decided to inline the two setup steps into each action.

The gpg-sign action was also broken due to #1: the arguments weren't properly passed in when the loop was added. In addition, I moved the loop inside the container so that it doesn't have to be started for each file to be signed, but only once.

alcaeus added 2 commits May 8, 2024 10:36
Using relative paths in a composite action does not import the action file from the action repository, but from the original repository. To avoid having to hardcode a branch name or version number in the actions, the two steps are inlined instead.
@alcaeus alcaeus force-pushed the fix-actions branch 2 times, most recently from a9a040e to ab3cb28 Compare May 8, 2024 09:06
Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@blink1073 blink1073 merged commit 1dc1ac8 into mongodb-labs:main May 8, 2024
@alcaeus alcaeus deleted the fix-actions branch May 8, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants