Skip to content

Conversation

@blink1073
Copy link
Member

Fixes #7.

I have set up the release environment and associated secrets/AWS assets.

@blink1073 blink1073 requested a review from alcaeus June 5, 2024 11:23
Copy link
Collaborator

@alcaeus alcaeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, nice idea to dogfood this! Just a question about the workflow permissions though

environment: release

steps:
- uses: actions/create-github-app-token@v1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this action necessitate the id-token: write permission?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed!

@blink1073 blink1073 requested a review from alcaeus June 5, 2024 11:35
@blink1073 blink1073 changed the title Add tagging action and contributing guide Add tagging workflow and contributing guide Jun 5, 2024
@blink1073 blink1073 merged commit c8c3b7a into mongodb-labs:main Jun 5, 2024
@blink1073 blink1073 deleted the v2-tagger branch June 5, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants