Skip to content

feat: add atlas streams support MONGOSH-1514 #1519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Aug 31, 2023
Merged

feat: add atlas streams support MONGOSH-1514 #1519

merged 11 commits into from
Aug 31, 2023

Conversation

shaketbaby
Copy link
Contributor

This PR adds Atlas Stream Processing support to the mongosh:

  • adds a new flag is_stream to the ConnectInfo type
  • changes default prompt to AtlasStreamProcessing> when is_stream is true
  • adds a new global object sp for doing streams related operations
@shaketbaby shaketbaby added the enhancement New feature or request label Jul 20, 2023
@shaketbaby shaketbaby self-assigned this Jul 20, 2023
@shaketbaby shaketbaby marked this pull request as draft July 20, 2023 06:54
mcasimir
mcasimir reviewed Jul 20, 2023
View reviewed changes
@shaketbaby shaketbaby force-pushed the feat-MONGOSH-1514-atlas-streams branch 2 times, most recently from 0ea4c3a to 80f5a82 Compare July 24, 2023 02:31
addaleax
addaleax reviewed Jul 24, 2023
View reviewed changes
@shaketbaby shaketbaby force-pushed the feat-MONGOSH-1514-atlas-streams branch 2 times, most recently from 75d55f0 to 5489f32 Compare July 27, 2023 05:40
addaleax
addaleax reviewed Aug 15, 2023
View reviewed changes
@shaketbaby shaketbaby marked this pull request as ready for review August 22, 2023 23:44
sharanlobana
sharanlobana reviewed Aug 23, 2023
View reviewed changes
addaleax
addaleax reviewed Aug 24, 2023
View reviewed changes
Copy link
Collaborator

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! It might be nice to wrap up the conversations around testing and interruption handling, but overall this should be good to go 👍
@shaketbaby shaketbaby force-pushed the feat-MONGOSH-1514-atlas-streams branch from 015e4cf to f9ce6f7 Compare August 30, 2023 11:41
@shaketbaby shaketbaby force-pushed the feat-MONGOSH-1514-atlas-streams branch from f9ce6f7 to 01d938e Compare August 30, 2023 22:07
@addaleax addaleax merged commit e6fcad9 into main Aug 31, 2023
@addaleax addaleax deleted the feat-MONGOSH-1514-atlas-streams branch August 31, 2023 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

4 participants

@shaketbaby @mcasimir @addaleax @sharanlobana