chore(shell-api): rename configureQueryAnalyzer option to match server MONGOSH-1499 #1500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
SERVER-78406 renamed the option from `sampleRate` to `samplesPerSecond`. Consequently, we should do the same here.
addaleax changed the title 
lerouxb approved these changes Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
SERVER-78406 renamed the option from
sampleRatetosamplesPerSecond. Consequently, we should do the same here.Also, SERVER-78265 added extra options to
analyzeShardKey. Consequently, we should allow passing through arbitrary keys from this method as well.(This fixes a CI failure on main.)