Skip to content

fix(cli-repl): keep the raw mode off for the whole duration of the eval MONGOSH-1433 #1460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 17, 2023
Merged

fix(cli-repl): keep the raw mode off for the whole duration of the eval MONGOSH-1433 #1460

merged 3 commits into from
May 17, 2023

Conversation

gribnoysup
Copy link
Collaborator

@gribnoysup gribnoysup commented May 12, 2023 •
edited
Loading

Fixes Ctrl+C behavior for mongosh running files by making sure that raw mode is disabled for the whole duration of the code evaluation inside ayncRepl.eval

TODO:

  • Add tests. Wanted to open PR already to kick of a CI run to make sure this doesn't break anything unexpectedly (existing cli-repl tests are still passing)
@gribnoysup gribnoysup changed the title fix(cli-repl): keep the raw mode off for the whole duration of the eval fix(cli-repl): keep the raw mode off for the whole duration of the eval MONGOSH-1433 May 12, 2023
@addaleax addaleax marked this pull request as ready for review May 17, 2023 10:13
@addaleax addaleax merged commit ee64a1b into main May 17, 2023
@addaleax addaleax deleted the mongosh-1433-ctrl-c-for-files branch May 17, 2023 11:43
kornilova203 pushed a commit to kornilova203/mongosh that referenced this pull request Sep 11, 2023
@gribnoysup
fix(cli-repl): keep the raw mode off for the whole duration of the ev…
aeefc8b 
…al MONGOSH-1433 (mongodb-js#1460)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@gribnoysup @addaleax