fix(shell-api): fix broken tsToSeconds conversion MONGOSH-1428 #1433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
`tsToSeconds()` has not been working as intended since it was first written. BSON `Timestamp` objects never had direct `t` or `i` properties, so the `if` condition here would never be met. Instead, if the function received a `Timestamp` object, it would implicitly convert it to a number (via the `Long` class’s `.toString()` conversion method). This happens to work out because `x/(2**32)` corresponds roughly to the time part for a `Timestamp` object `t` when interpreted as a `Long`. I am not sure why exactly this breaks in the way it does described in the ticket (where this function seems to return `NaN`), but making this function work as intended should address the issue.
Anemy approved these changes Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
tsToSeconds()has not been working as intended since it was first written. BSONTimestampobjects never had directtoriproperties, so theifcondition here would never be met. Instead, if the function received aTimestampobject, it would implicitly convert it to a number (via theLongclass’s.toString()conversion method). This happens to work out becausex/(2**32)corresponds roughly to the time part for aTimestampobjecttwhen interpreted as aLong.I am not sure why exactly this breaks in the way it does described in the ticket (where this function seems to return
NaN), but making this function work as intended should address the issue.